From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Sat, 17 Jan 2015 03:39:46 +0100
Subject: [U-Boot] [PATCHv1 01/22] arm: socfpga: spl: Add main sdram code
In-Reply-To: <20150116190420.GD8425@amd>
References: <1421253662-27222-1-git-send-email-dinguyen@opensource.altera.com>
	<201501150034.16486.marex@denx.de> <20150116190420.GD8425@amd>
Message-ID: <201501170339.46171.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Friday, January 16, 2015 at 08:04:20 PM, Pavel Machek wrote:
> Hi!

Hi!

> > > +void wait_di_buffer(void)
> > > +{
> > > +	if (debug_data->di_report.cur_samples == NUM_DI_SAMPLE)	{
> > > +		debug_data->di_report.flags |= DI_REPORT_FLAGS_READY;
> > > +		while (debug_data->di_report.cur_samples != 0)
> > > +			;
> > 
> > Please get rid of such endless loops, since the platform might get stuck
> > forever in them.
> 
> What would you propose in case of timeout? Message on serial console
> and reboot?

Yes, reboot and try again would work I suspect.

> Endless loop should trigger watchdog, anyway, no?

If and only if the WDT is enabled, which is not necessarily the case.

Best regards,
Marek Vasut