From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] common: mark commands as default to match "config_cmd_default.h"
Date: Tue, 20 Jan 2015 13:52:42 +0900 [thread overview]
Message-ID: <20150120135242.38B9.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <CAPnjgZ0NZ01wx_Qk18bWB3L=cSjOAQSY8ANJpCJda5g8waLxiA@mail.gmail.com>
Hi Simon, Alexey,
On Thu, 15 Jan 2015 12:44:16 -0700
Simon Glass <sjg@chromium.org> wrote:
>>> Frankly I don't like this approach with post-processing steps. It will
>>> inevitably end-up with messed up configs.
>>>
>>> Why don't we just use default values in Kconfig for ARCH/SOC/Board?
>>> It's pretty obvious that 1 board may have N flavors but then have a
>>> baseline options selected in "board/vendor/board_name/Kconfig" and only
>>> put options that differ between boards in your defconfigs.
>>>
>>> This way "savedefconfig" will automatically strip down all extra lines
>>> for a particular board.
>>>
>>> This is how things work in Linux kernel and Buildroot Kconfig-based
>>> build systems. Probably I'm missing something here because U-Boot
>>> differs from mentioned projects in some aspects - if so please correct
>>> me.
>>
>> I started with this approach and Masahiro was not very keen on it. I'm
>> OK with it, particularly as it is already supported, but I wonder
>> whether we can do better.
Shall we go with this way?
It is true that I was not very keen on it at first,
but after discussion with you, I understand that
this is the best solution we can do now in terms of
code maintainability.
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2015-01-20 4:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-03 13:20 [U-Boot] [PATCH 0/2] select default commands in Kconfig Alexey Brodkin
2015-01-03 13:20 ` [U-Boot] [PATCH 1/2] common: mark commands as default to match "config_cmd_default.h" Alexey Brodkin
2015-01-05 15:34 ` Masahiro YAMADA
2015-01-09 20:09 ` Alexey Brodkin
2015-01-14 4:05 ` Masahiro Yamada
2015-01-14 4:18 ` Simon Glass
2015-01-14 8:18 ` Alexey Brodkin
2015-01-15 14:46 ` Simon Glass
2015-01-15 19:10 ` Masahiro YAMADA
2015-01-15 19:44 ` Simon Glass
2015-01-15 21:49 ` Alexey Brodkin
2015-01-16 16:55 ` Simon Glass
2015-01-19 12:52 ` Masahiro Yamada
2015-01-19 12:22 ` Masahiro Yamada
2015-01-20 4:52 ` Masahiro Yamada [this message]
2015-01-22 15:30 ` Simon Glass
2015-01-15 18:36 ` Masahiro YAMADA
2015-01-15 21:22 ` Alexey Brodkin
2015-01-19 12:34 ` Masahiro Yamada
2015-01-03 13:20 ` [U-Boot] [PATCH 2/2] config_cmd_default.h: wrap each definition in "ifndef" Alexey Brodkin
2015-01-09 21:21 ` Alexey Brodkin
2015-01-14 4:12 ` Masahiro Yamada
2015-01-14 6:23 ` Alexey Brodkin
2015-01-14 6:42 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150120135242.38B9.AA925319@jp.panasonic.com \
--to=yamada.m@jp.panasonic.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox