From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Thu, 22 Jan 2015 00:24:52 +0100 Subject: [U-Boot] [PATCH 1/5] Add debug output to mx29 SPL source files In-Reply-To: <1421841318-3014-2-git-send-email-gruss@tss-engineering.com> References: <1421841318-3014-1-git-send-email-gruss@tss-engineering.com> <1421841318-3014-2-git-send-email-gruss@tss-engineering.com> Message-ID: <201501220024.52212.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday, January 21, 2015 at 12:55:14 PM, Graeme Russ wrote: > Signed-off-by: Graeme Russ Hi! - Commit message is missing. - Some of the debug outputs are missing newline (\n) character - You can use __func__ and __LINE__ in the debug output to better specify where the debug spit happened. Oh, and the CC list looks pretty random. You can just add "Cc: " tag into the patches so that git handles it correctly. Best regards, Marek Vasut