public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/2] sunxi: video: Add support for Hitachi tx18d42vm LVDS LCD panels
Date: Thu, 22 Jan 2015 18:37:20 +0100	[thread overview]
Message-ID: <20150122183720.60c5e906@crub> (raw)
In-Reply-To: <1421762882-14066-3-git-send-email-hdegoede@redhat.com>

On Tue, 20 Jan 2015 15:08:02 +0100
Hans de Goede <hdegoede@redhat.com> wrote:
...
> @@ -976,6 +977,14 @@ static int sunxi_ssd2828_init(const struct ctfb_res_modes *mode)
>  }
>  #endif /* CONFIG_VIDEO_LCD_SSD2828 */
>  
> +#ifdef CONFIG_VIDEO_LCD_HITACHI_TX18D42VM
> +static void sunxi_hitachi_tx18d42vm_init(void)
> +{
> +	mdelay(50); /* Wait for lcd controller power on */
> +	hitachi_tx18d42vm_init();
> +}
> +#endif

Could you please test if 

#if IS_ENABLED(CONFIG_VIDEO_LCD_HITACHI_TX18D42VM)

#endif

works here around sunxi_hitachi_tx18d42vm_init() definition ?

Now with Kconfig it should. I'd prefer this variant instead
of #ifdef.

...
> @@ -1004,6 +1013,9 @@ static void sunxi_mode_set(const struct ctfb_res_modes *mode,
>  		break;
>  	case sunxi_monitor_lcd:
>  		sunxi_lcdc_panel_enable();
> +#ifdef CONFIG_VIDEO_LCD_HITACHI_TX18D42VM
> +		sunxi_hitachi_tx18d42vm_init();
> +#endif

And here, please try to use

	if (IS_ENABLED(CONFIG_VIDEO_LCD_HITACHI_TX18D42VM))
		sunxi_hitachi_tx18d42vm_init();

Thanks,

Anatolij

  reply	other threads:[~2015-01-22 17:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 14:08 [U-Boot] [PATCH v2 0/2] video: Add support for Hitachi tx18d42vm LVDS LCD Hans de Goede
2015-01-20 14:08 ` [U-Boot] [PATCH v2 1/2] video: Add support for Hitachi tx18d42vm LVDS LCD panels Hans de Goede
2015-01-22 17:36   ` Anatolij Gustschin
2015-01-20 14:08 ` [U-Boot] [PATCH v2 2/2] sunxi: " Hans de Goede
2015-01-22 17:37   ` Anatolij Gustschin [this message]
2015-01-22 19:43     ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150122183720.60c5e906@crub \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox