From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 19/26] dm: i2c: Move slave details to child platdata
Date: Mon, 26 Jan 2015 11:05:31 +0900 [thread overview]
Message-ID: <20150126110531.5EB1.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <1422199640-25811-20-git-send-email-sjg@chromium.org>
On Sun, 25 Jan 2015 08:27:13 -0700
Simon Glass <sjg@chromium.org> wrote:
> At present we go through various contortions to store the I2C's chip
> address in its private data. This only exists when the chip is active so
> must be set up when it is probed. Until the device is probed we don't
> actually record what address it will appear on.
>
> However, now that we can support per-child platform data, we can use that
> instead. This allows us to set up the address when the child is bound,
> and avoid the messy contortions.
>
> Unfortunately this is a fairly large change and it seems to be difficult to
> break it down further.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v3:
> - Add missing 'static' to two functions
> - Remove unnecessary per_child_auto_alloc_size value
I tested this series on my board.
I am OK with the change in the UniPhier I2C driver area.
Reviewed-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
next prev parent reply other threads:[~2015-01-26 2:05 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-25 15:26 [U-Boot] [PATCH v3 0/26] dm: Add additional bus functionality Simon Glass
2015-01-25 15:26 ` [U-Boot] [PATCH v3 01/26] dm: i2c: Provide an offset length parameter where needed Simon Glass
2015-01-26 20:09 ` Simon Glass
2015-01-25 15:26 ` [U-Boot] [PATCH v3 02/26] dm: Don't run tests if U-Boot cannot be built Simon Glass
2015-01-26 20:09 ` Simon Glass
2015-01-25 15:26 ` [U-Boot] [PATCH v3 03/26] dm: core: Improve comments for uclass_first/next_device() Simon Glass
2015-01-26 20:09 ` Simon Glass
2015-01-25 15:26 ` [U-Boot] [PATCH v3 04/26] dm: core: Set device tree node for root device Simon Glass
2015-01-26 20:09 ` Simon Glass
2015-01-25 15:26 ` [U-Boot] [PATCH v3 05/26] dm: core: Tidy up error handling in device_bind() Simon Glass
2015-01-26 20:09 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 06/26] dm: core: Allocate platform data when binding a device Simon Glass
2015-01-26 1:57 ` Masahiro Yamada
2015-01-26 20:09 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 07/26] dm: core: Allow parents to have platform data for their children Simon Glass
2015-01-26 1:56 ` Masahiro Yamada
2015-01-26 20:10 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 08/26] dm: core: Allow uclasses to specify platdata for a device's children Simon Glass
2015-01-26 20:10 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 09/26] dm: core: Add a post_bind method for parents Simon Glass
2015-01-26 20:10 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 10/26] dm: core: Add a function to get a device's uclass ID Simon Glass
2015-01-26 1:58 ` Masahiro Yamada
2015-01-26 20:10 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 11/26] dm: core: Add a flag to control sequence numbering Simon Glass
2015-01-26 20:10 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 12/26] dm: core: Allow uclasses to specify private data for a device's children Simon Glass
2015-01-26 2:00 ` Masahiro Yamada
2015-01-26 20:11 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 13/26] dm: spi: Move the per-child data size to the uclass Simon Glass
2015-01-26 20:11 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 14/26] dm: core: Allow the uclass to set up a device's child after binding Simon Glass
2015-01-26 20:12 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 15/26] dm: sandbox: sf: Tidy up the error handling in sandbox_sf_probe() Simon Glass
2015-01-26 20:12 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 16/26] dm: core: Allow uclass to set up a device's child before it is probed Simon Glass
2015-01-26 20:13 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 17/26] dm: spi: Set up the spi_slave device pointer in child_pre_probe() Simon Glass
2015-01-26 20:13 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 18/26] dm: spi: Move slave details to child platdata Simon Glass
2015-01-26 20:13 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 19/26] dm: i2c: " Simon Glass
2015-01-26 2:05 ` Masahiro Yamada [this message]
2015-01-26 20:13 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 20/26] dm: tegra: Drop unused COMPAT features for I2C, SPI Simon Glass
2015-01-26 20:13 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 21/26] dm: exynos: Drop unused COMPAT features for SPI Simon Glass
2015-01-26 6:53 ` Minkyu Kang
2015-01-26 20:13 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 22/26] dm: core: Ignore disabled devices when binding Simon Glass
2015-01-26 20:14 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 23/26] dm: cros_ec: Don't require protocol 3 support Simon Glass
2015-01-26 20:14 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 24/26] dm: cros_ec: Move cros_ec_i2c over to driver model Simon Glass
2015-01-26 20:14 ` Simon Glass
2015-01-27 0:17 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 25/26] dm: cros_ec_spi: Remove old pre-driver-model code Simon Glass
2015-01-26 20:14 ` Simon Glass
2015-01-25 15:27 ` [U-Boot] [PATCH v3 26/26] dm: Update documentation for new bus features Simon Glass
2015-01-26 20:14 ` Simon Glass
2015-01-26 2:08 ` [U-Boot] [PATCH v3 0/26] dm: Add additional bus functionality Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150126110531.5EB1.AA925319@jp.panasonic.com \
--to=yamada.m@jp.panasonic.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox