From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net/designware: add error message on DMA reset timeout
Date: Fri, 30 Jan 2015 11:04:19 +0100 [thread overview]
Message-ID: <201501301104.19590.marex@denx.de> (raw)
In-Reply-To: <1422601834.4846.2.camel@synopsys.com>
On Friday, January 30, 2015 at 08:10:34 AM, Alexey Brodkin wrote:
> Hi Marek, Tom,
>
> On Fri, 2015-01-16 at 22:16 +0100, Pavel Machek wrote:
> > On Tue 2015-01-13 17:10:24, Alexey Brodkin wrote:
> > > If for some reason DMA module fails to reset user oserves only this:
> > > --->---
> > > # dhcp
> > > Trying dwmac.e0018000
> > > FAIL
> > > --->---
> > >
> > > This message makes not much sense.
> > > With proposed change error message will be more helpful:
> > > --->---
> > > # dhcp
> > > Trying dwmac.e0018000
> > > DMA reset timeout
> > > FAIL
> > > --->---
> > >
> > > For example user may do power toggle to recover board functionality.
> > >
> > > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > > Cc: Chin Liang See <clsee@altera.com>
> > > Cc: Dinh Nguyen <dinguyen@altera.com>
> > > Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> > > Cc: Tom Rini <trini@ti.com>
> > > Cc: Wolfgang Denk <wd@denx.de>
> >
> > Acked-by: Pavel Machek <pavel@denx.de>
>
> Any chance for this trivial change to be applied?
Joe, can you please pick this ?
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-01-30 10:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 14:10 [U-Boot] [PATCH] net/designware: add error message on DMA reset timeout Alexey Brodkin
2015-01-13 14:53 ` Tom Rini
2015-01-16 21:16 ` Pavel Machek
[not found] ` <1422601834.4846.2.camel@synopsys.com>
2015-01-30 10:04 ` Marek Vasut [this message]
2015-01-30 16:19 ` Joe Hershberger
2015-01-30 20:58 ` Joe Hershberger
2015-01-30 21:57 ` Joe Hershberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201501301104.19590.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox