From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] cmd_fdt: Print the control fdt in terms of virtual memory
Date: Tue, 3 Feb 2015 23:30:13 +0100 [thread overview]
Message-ID: <20150203233013.742ce243@lilith> (raw)
In-Reply-To: <1423001167-22266-2-git-send-email-joe.hershberger@ni.com>
Hello Joe,
On Tue, 3 Feb 2015 16:06:07 -0600, Joe Hershberger
<joe.hershberger@ni.com> wrote:
> If you want to inspect the control device tree using the fdt command,
> the "fdt address -c" command previously unhelpfully printed the phys
> memory address of the device tree. That address could not then be used
> to set the fdt address for inspection.
Nitpick: your commit message says what the problem is, but does not say
what solution is chosen. Granted, here understanding that from the code
is trivial, but I'd still like it if the message made it clear.
> Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
>
> ---
>
> common/cmd_fdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/cmd_fdt.c b/common/cmd_fdt.c
> index 51c585b..868558d 100644
> --- a/common/cmd_fdt.c
> +++ b/common/cmd_fdt.c
> @@ -111,7 +111,7 @@ static int do_fdt(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> if (!blob || !fdt_valid(&blob))
> return 1;
> printf("The address of the fdt is %#08lx\n",
> - control ? (ulong)blob :
> + control ? (ulong)map_to_sysmem(blob) :
> getenv_hex("fdtaddr", 0));
> return 0;
> }
> --
> 1.7.11.5
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Amicalement,
--
Albert.
next prev parent reply other threads:[~2015-02-03 22:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 22:06 [U-Boot] [PATCH 1/2] cmd_fdt: Actually fix fdt command in sandbox Joe Hershberger
2015-02-03 22:06 ` [U-Boot] [PATCH 2/2] cmd_fdt: Print the control fdt in terms of virtual memory Joe Hershberger
2015-02-03 22:30 ` Albert ARIBAUD [this message]
2015-02-04 0:35 ` [U-Boot] [PATCH 1/2] cmd_fdt: Actually fix fdt command in sandbox Simon Glass
2015-02-04 1:04 ` [U-Boot] [PATCH v2 " Joe Hershberger
2015-02-04 1:04 ` [U-Boot] [PATCH v2 2/2] cmd_fdt: Print the control fdt in terms of virtual memory Joe Hershberger
2015-02-05 2:50 ` Simon Glass
2015-02-05 2:50 ` [U-Boot] [PATCH v2 1/2] cmd_fdt: Actually fix fdt command in sandbox Simon Glass
2015-02-05 3:56 ` [U-Boot] [PATCH v3 " Joe Hershberger
2015-02-05 3:56 ` [U-Boot] [PATCH v3 2/2] cmd_fdt: Print the control fdt in terms of virtual memory Joe Hershberger
2015-02-06 5:11 ` Simon Glass
2015-02-06 5:59 ` Simon Glass
2015-02-06 5:11 ` [U-Boot] [PATCH v3 1/2] cmd_fdt: Actually fix fdt command in sandbox Simon Glass
2015-02-06 5:59 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150203233013.742ce243@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox