From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Mon, 9 Feb 2015 18:05:31 +0100 Subject: [U-Boot] [PATCHv1 13/22] arm: socfpga: spl: Add s_init In-Reply-To: <54D8E55A.4010308@opensource.altera.com> References: <1421253662-27222-1-git-send-email-dinguyen@opensource.altera.com> <201502071434.16275.marex@denx.de> <54D8E55A.4010308@opensource.altera.com> Message-ID: <201502091805.32020.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday, February 09, 2015 at 05:50:34 PM, Dinh Nguyen wrote: Hi! [...] > >>>> + > >>>> +#endif /* CONFIG_SPL_BUILD */ > >>>> + > >>>> + /* Configure the L2 controller to make SDRAM start at 0 */ > >>>> + writel(0x1, (SOCFPGA_MPUL2_ADDRESS + SOCFPGA_MPUL2_ADRFLTR_START)); > >>> > >>> This as well. > >> > >> This call has to stay because we want to map the SDRAM to 0x0 in the > >> SPL. The call in arch_early_init_r() is in u-boot, and thus is too late. > > > > Roger, but please remove the other invocation once the SPL is in place. > > OK? > > Yes, I can remove it in the series? Roger, thank you. Please address Simon's email too :) Best regards, Marek Vasut