public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] net: phy: Add ability to program the ksz9031 skew values from the uboot env
Date: Mon, 9 Feb 2015 20:18:52 +0100	[thread overview]
Message-ID: <201502092018.52128.marex@denx.de> (raw)
In-Reply-To: <1423493073-9462-3-git-send-email-vbridger@opensource.altera.com>

On Monday, February 09, 2015 at 03:44:33 PM, Vince Bridgers wrote:
> This patch adds the ability for the Micrel ksz9031 PHY driver to detect
> skew settings from the UBoot environment and program those values at PHY
> initialization time. This is a first step towards setting these values from
> the UBoot environment or the Micrel PHY devicetree once supported. The skew
> values may be negative or positive, therefore depends on UBoot environment
> support to read positive or negative values in units of picoseconds.
> 
> Signed-off-by: Vince Bridgers <vbridger@opensource.altera.com>

Hi!

We already do this kind of a programming in board/altera/socfpga/socfpga.c
in board_phy_config(), don't we ?

Also, see [1], once I apply this, the DT support (not DM) for SoCFPGA will
become mandatory. Won't it make more sense to pull these values from the
DT instead of poluting the board environment with those please ?

Thanks!

[1] http://git.denx.de/?p=u-boot/u-boot-
socfpga.git;a=shortlog;h=refs/heads/topic/vip-arriav

Best regards,
Marek Vasut

  reply	other threads:[~2015-02-09 19:18 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09 14:44 [U-Boot] [PATCH 0/2] Add getenv_long and Micrel ksz9031 skew settings Vince Bridgers
2015-02-09 14:44 ` [U-Boot] [PATCH 1/2] cmd: Add getenv_long to support reading signed integers from the uboot env Vince Bridgers
2015-02-09 19:12   ` Marek Vasut
2015-02-09 14:44 ` [U-Boot] [PATCH 2/2] net: phy: Add ability to program the ksz9031 skew values " Vince Bridgers
2015-02-09 19:18   ` Marek Vasut [this message]
2015-02-09 21:31     ` Vince Bridgers
2015-02-10 18:51       ` Marek Vasut
2015-02-11  7:08         ` Stefan Roese
2015-02-11  8:07           ` Joe Hershberger
2015-02-11  8:26             ` Stefan Roese
2015-02-13 16:19               ` Vince Bridgers
2015-02-13 16:44                 ` Stefan Roese
2015-02-15 14:43                   ` Marek Vasut
2015-02-13 16:17             ` Vince Bridgers
2015-02-13 16:05           ` Vince Bridgers
2015-02-13 15:57         ` Vince Bridgers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201502092018.52128.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox