From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 11/14] usb: UniPhier: add UniPhier on-chip xHCI host driver support
Date: Tue, 17 Feb 2015 20:51:48 +0100 [thread overview]
Message-ID: <201502172051.48111.marex@denx.de> (raw)
In-Reply-To: <1424156430-23499-12-git-send-email-yamada.m@jp.panasonic.com>
On Tuesday, February 17, 2015 at 08:00:27 AM, Masahiro Yamada wrote:
> Support xHCI host driver used on Panasonic UniPhier platform.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
> Hi Marek,
>
> I want apply this patch onto u-boot-uniphier/master
> to avoid conflicts.
>
> If you are OK with it, could you issue your Acked-by tag, please?
[...]
> +static int get_uniphier_xhci_base(int index, struct xhci_hccr **base)
> +{
> + int offset;
> +
> + for (offset = fdt_node_offset_by_compatible(FDT, 0, COMPAT);
> + offset >= 0;
> + offset = fdt_node_offset_by_compatible(FDT, offset, COMPAT)) {
> + if (index == 0) {
> + *base = (struct xhci_hccr *)
> + fdtdec_get_addr(FDT, offset, "reg");
Hi!
does it make sense to check if the value returned by fdtdec_get_addr() is
valid here?
Otherwise,
Acked-by: Marek Vasut <marex@denx.de>
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-02-17 19:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-17 7:00 [U-Boot] [PATCH 0/14] ARM: UniPhier: bug fixes, refactorings and new features Masahiro Yamada
2015-02-17 7:00 ` [U-Boot] [PATCH 01/14] ARM: UniPhier: fix comments in PH1-Pro4 SBC code Masahiro Yamada
2015-02-17 7:00 ` [U-Boot] [PATCH 02/14] ARM: UniPhier: fix SBC init code Masahiro Yamada
2015-02-17 7:00 ` [U-Boot] [PATCH 03/14] ARM: UniPhier: split clkrst_init() into two functions Masahiro Yamada
2015-02-17 7:00 ` [U-Boot] [PATCH 04/14] ARM: UniPhier: enable STDMAC for EHCI Masahiro Yamada
2015-02-17 7:00 ` [U-Boot] [PATCH 05/14] ARM: UniPhier: remove EHCI platform devices Masahiro Yamada
2015-02-17 7:00 ` [U-Boot] [PATCH 06/14] ARM: UniPhier: move uniphier_ehci_reset() function Masahiro Yamada
2015-02-17 7:00 ` [U-Boot] [PATCH 07/14] ARM: UniPhier: replace "usb-ehci" with "generic-ehci" Masahiro Yamada
2015-02-17 7:00 ` [U-Boot] [PATCH 08/14] ARM: UniPhier: add I/O pin settings for xHCI on PH1-Pro4 Masahiro Yamada
2015-02-17 7:00 ` [U-Boot] [PATCH 09/14] ARM: UniPhier: enable xHCI and GIO cores for PH1-Pro4 Masahiro Yamada
2015-02-17 7:00 ` [U-Boot] [PATCH 10/14] ARM: UniPhier: add xHCI device nodes to PH1-Pro4 device tree Masahiro Yamada
2015-02-17 7:00 ` [U-Boot] [PATCH 11/14] usb: UniPhier: add UniPhier on-chip xHCI host driver support Masahiro Yamada
2015-02-17 19:51 ` Marek Vasut [this message]
2015-02-20 13:04 ` Masahiro Yamada
2015-02-20 15:54 ` Marek Vasut
2015-02-18 5:01 ` Simon Glass
2015-02-20 12:12 ` Masahiro Yamada
2015-02-20 17:21 ` Simon Glass
2015-02-24 4:54 ` Masahiro Yamada
2015-02-24 16:46 ` Simon Glass
2015-02-17 7:00 ` [U-Boot] [PATCH 12/14] ARM: UniPhier: switch to xHCI for PH1-Pro4 Masahiro Yamada
2015-02-17 7:00 ` [U-Boot] [PATCH 13/14] ARM: UniPhier: support 1CS support card for all the UniPhier SoCs Masahiro Yamada
2015-02-17 7:00 ` [U-Boot] [PATCH 14/14] ARM: UniPhier: consolidate MEMCONF setting code Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201502172051.48111.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox