From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Tue, 17 Feb 2015 20:51:48 +0100
Subject: [U-Boot] [PATCH 11/14] usb: UniPhier: add UniPhier on-chip xHCI
	host driver support
In-Reply-To: <1424156430-23499-12-git-send-email-yamada.m@jp.panasonic.com>
References: <1424156430-23499-1-git-send-email-yamada.m@jp.panasonic.com>
 <1424156430-23499-12-git-send-email-yamada.m@jp.panasonic.com>
Message-ID: <201502172051.48111.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tuesday, February 17, 2015 at 08:00:27 AM, Masahiro Yamada wrote:
> Support xHCI host driver used on Panasonic UniPhier platform.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
> Hi Marek,
> 
> I want apply this patch onto u-boot-uniphier/master
> to avoid conflicts.
> 
> If you are OK with it, could you issue your Acked-by tag, please?

[...]

> +static int get_uniphier_xhci_base(int index, struct xhci_hccr **base)
> +{
> +	int offset;
> +
> +	for (offset = fdt_node_offset_by_compatible(FDT, 0, COMPAT);
> +	     offset >= 0;
> +	     offset = fdt_node_offset_by_compatible(FDT, offset, COMPAT)) {
> +		if (index == 0) {
> +			*base = (struct xhci_hccr *)
> +					fdtdec_get_addr(FDT, offset, "reg");

Hi!

does it make sense to check if the value returned by fdtdec_get_addr() is
valid here?

Otherwise,

Acked-by: Marek Vasut <marex@denx.de>

Best regards,
Marek Vasut