From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Date: Thu, 19 Feb 2015 10:04:18 +0100 Subject: [U-Boot] [PATCH v2 09/12] tegra124: Add PSCI support for Tegra124 In-Reply-To: <48840a4f6b07a748ff10c20ffa69f6732c967b35.1424091289.git.jan.kiszka@siemens.com> References: <48840a4f6b07a748ff10c20ffa69f6732c967b35.1424091289.git.jan.kiszka@siemens.com> Message-ID: <20150219090417.GD5086@ulmo.nvidia.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de One more thing... On Mon, Feb 16, 2015 at 01:54:46PM +0100, Jan Kiszka wrote: > diff --git a/arch/arm/cpu/armv7/tegra-common/psci.S b/arch/arm/cpu/armv7/tegra-common/psci.S [...] > +ENTRY(psci_arch_init) > + mov r6, lr > + > + mrc p15, 0, r5, c1, c1, 0 @ Read SCR > + bic r5, r5, #1 @ Secure mode > + mcr p15, 0, r5, c1, c1, 0 @ Write SCR > + isb > + > + @ lock reset vector > + ldr r4, =TEGRA_SB_CSR_0 > + ldr r5, [r4] > + orr r5, r5, #NS_RST_VEC_WR_DIS > + str r5, [r4] Perhaps extend the comment to mention that this locks the reset vector for accesses from non-secure mode, otherwise it might be confusing that psci_cpu_on actually writes the reset vector. Thierry -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: