From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masahiro Yamada Date: Fri, 20 Feb 2015 16:32:38 +0900 Subject: [U-Boot] [PATCH v2 6/8] kconfig: malloc: add option for skip memset at malloc init In-Reply-To: References: <54E4882D.4010300@samsung.com> Message-ID: <20150220163238.DDBC.AA925319@jp.panasonic.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thu, 19 Feb 2015 11:59:07 -0700 Simon Glass wrote: > +Masahiro > > Hi, > > On 18 February 2015 at 05:40, Przemyslaw Marczak wrote: > > Hi Simon, > > > > On 02/18/2015 05:32 AM, Simon Glass wrote: > >> > >> Hi Przemyslaw, > >> > >> On 16 February 2015 at 08:13, Przemyslaw Marczak > >> wrote: > >>> > >>> Signed-off-by: Przemyslaw Marczak > >>> --- > >>> Kconfig | 26 +++++++++++++++++++------- > >>> 1 file changed, 19 insertions(+), 7 deletions(-) > >>> > >>> diff --git a/Kconfig b/Kconfig > >>> index 4157da3..e08e44a 100644 > >>> --- a/Kconfig > >>> +++ b/Kconfig > >>> @@ -57,13 +57,25 @@ config CC_OPTIMIZE_FOR_SIZE > >>> This option is enabled by default for U-Boot. > >> > >> > >> Ah, you have done this. Then I think you can merge this patch with the > >> dlmalloc patch and drop the README one. > >> > > > > Shouldn't we keep both, README and Kconfig help? > > Kconfig is just a configuration tool, README is a documentation. > > Sometimes it could be faster to find something in the text instead of > > config. > > Agreed, but isn't it going to be a pain to add it in both places and > keep it in sync? Maybe we could create a script which creates a > README.kconfig containing all the options and help. > I agree with Simon. README is useful when we need a wider and more general explanation about a feature, for ex. doc/driver-model/README.txt Per-config explanation should be documented in Kconfig only. Another reasone I prefer Kconfig help is: When we remove a CONFIG from Kconfig, the documentation in a separete README might be left over. BTW, I did not know that U-Boot filled all the malloc space with zero. I guess our consensus is that malloc() returns uninitialized memory. So, I am happy with this patch. (Perhaps, could it be enabled by default? ) Best Regards Masahiro Yamada