From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Mon, 23 Feb 2015 16:04:56 +0100
Subject: [U-Boot] [PATCH 03/11] usb: dwc3: Add BIT() macro
In-Reply-To: <1424700152-8554-4-git-send-email-l.majewski@samsung.com>
References: <1424700152-8554-1-git-send-email-l.majewski@samsung.com>
 <1424700152-8554-4-git-send-email-l.majewski@samsung.com>
Message-ID: <201502231604.56231.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday, February 23, 2015 at 03:02:24 PM, Lukasz Majewski wrote:
> From: Inha Song <ideal.song@samsung.com>
> 
> Signed-off-by: Inha Song <ideal.song@samsung.com>

Is such confusing macro really necessary please ?

Moreover, the #define BIT(x) (1 << x) should really be #define BIT(x) (1 << (x))
(with (x) in round brackets).

Best regards,
Marek Vasut