From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Mon, 23 Feb 2015 17:57:02 +0100
Subject: [U-Boot] [PATCHv1 01/22] arm: socfpga: spl: Add main sdram code
In-Reply-To: <54EB57D9.6040203@opensource.altera.com>
References: <1421253662-27222-1-git-send-email-dinguyen@opensource.altera.com>
 <54EB5740.10005@opensource.altera.com>
 <54EB57D9.6040203@opensource.altera.com>
Message-ID: <201502231757.02771.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Monday, February 23, 2015 at 05:39:53 PM, Dinh Nguyen wrote:
> On 2/23/15 10:37 AM, Dinh Nguyen wrote:
> > On 2/15/15 5:25 PM, Pavel Machek wrote:
> >> Hi!
> >> 
> >>> +#if ENABLE_BRINGUP_DEBUGGING
> >> 
> >> Could we get rid of this for initial merge?
> > 
> > Yeah, it can be removed.
> > 
> >>> +static inline void reg_file_set_sub_stage(uint32_t set_sub_stage)
> >>> +{
> >>> +	/* Read the current group and stage */
> >>> +	uint32_t cur_stage_group = IORD_32DIRECT(REG_FILE_CUR_STAGE, 0);
> >> 
> >> Could normal u-boot memory access macros be used here?
> > 
> > I'll look..
> 
> Actually, I'm reworking this whole IORD_* that uses the AVL_TO_APB to a
> function. This was already commented by Marek.

If this can be switched to regular readl()/writel() stuff, then please do
so, since that'd be much less confusing.

Best regards,
Marek Vasut