[U-Boot] [PATCHv1 01/22] arm: socfpga: spl: Add main sdram code

Marek Vasut
2015-01-17T02:39:46Z

On Friday, January 16, 2015 at 08:04:20 PM, Pavel Machek wrote:
> Hi!

Hi!

> > > +void wait_di_buffer(void)
> > > +{
> > > + if (debug_data->di_report.cur_samples == NUM_DI_SAMPLE) {
> > > + debug_data->di_report.flags |= DI_REPORT_FLAGS_READY;
> > > + while (debug_data->di_report.cur_samples != 0)
> > > + ;
> >
> > Please get rid of such endless loops, since the platform might get stuck
> > forever in them.
>
> What would you propose in case of timeout? Message on serial console
> and reboot?

Yes, reboot and try again would work I suspect.

> Endless loop should trigger watchdog, anyway, no?

If and only if the WDT is enabled, which is not necessarily the case.

Best regards,
Marek Vasut