public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] sunxi: Make CONFIG_DRAM_TPR3 apply to sun[57]i
@ 2015-02-23 20:44 Adam Sampson
  2015-02-24  2:53 ` [U-Boot] [linux-sunxi] " Siarhei Siamashka
  0 siblings, 1 reply; 3+ messages in thread
From: Adam Sampson @ 2015-02-23 20:44 UTC (permalink / raw)
  To: u-boot

The tpr3 (timing skew) parameter is used in all supported versions of
the sunxi DRAM controller, but it was only enabled for sun4i in
47e3501a76894f4ba08bc61f33774bd5d39ff464.

Signed-off-by: Adam Sampson <ats@offog.org>
---
 board/sunxi/dram_sun5i_auto.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/sunxi/dram_sun5i_auto.c b/board/sunxi/dram_sun5i_auto.c
index e52d54c..660b18e 100644
--- a/board/sunxi/dram_sun5i_auto.c
+++ b/board/sunxi/dram_sun5i_auto.c
@@ -24,7 +24,7 @@ static struct dram_para dram_para = {
 #	include "dram_timings_sun4i.h"
 	.active_windowing = 1,
 #endif
-	.tpr3 = 0,
+	.tpr3 = CONFIG_DRAM_TPR3,
 	.tpr4 = 0,
 	.tpr5 = 0,
 	.emr1 = CONFIG_DRAM_EMR1,
-- 
1.7.10.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [linux-sunxi] [PATCH] sunxi: Make CONFIG_DRAM_TPR3 apply to sun[57]i
  2015-02-23 20:44 [U-Boot] [PATCH] sunxi: Make CONFIG_DRAM_TPR3 apply to sun[57]i Adam Sampson
@ 2015-02-24  2:53 ` Siarhei Siamashka
  2015-02-24 16:39   ` Hans de Goede
  0 siblings, 1 reply; 3+ messages in thread
From: Siarhei Siamashka @ 2015-02-24  2:53 UTC (permalink / raw)
  To: u-boot

On Mon, 23 Feb 2015 20:44:10 +0000
Adam Sampson <ats@offog.org> wrote:

> The tpr3 (timing skew) parameter is used in all supported versions of
> the sunxi DRAM controller, but it was only enabled for sun4i in
> 47e3501a76894f4ba08bc61f33774bd5d39ff464.
> 
> Signed-off-by: Adam Sampson <ats@offog.org>
> ---
>  board/sunxi/dram_sun5i_auto.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/board/sunxi/dram_sun5i_auto.c b/board/sunxi/dram_sun5i_auto.c
> index e52d54c..660b18e 100644
> --- a/board/sunxi/dram_sun5i_auto.c
> +++ b/board/sunxi/dram_sun5i_auto.c
> @@ -24,7 +24,7 @@ static struct dram_para dram_para = {
>  #	include "dram_timings_sun4i.h"
>  	.active_windowing = 1,
>  #endif
> -	.tpr3 = 0,
> +	.tpr3 = CONFIG_DRAM_TPR3,
>  	.tpr4 = 0,
>  	.tpr5 = 0,
>  	.emr1 = CONFIG_DRAM_EMR1,

Oops. Thanks for spotting this.

Acked-by: Siarhei Siamashka <siarhei.siamashka@gmail.com>

-- 
Best regards,
Siarhei Siamashka

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [linux-sunxi] [PATCH] sunxi: Make CONFIG_DRAM_TPR3 apply to sun[57]i
  2015-02-24  2:53 ` [U-Boot] [linux-sunxi] " Siarhei Siamashka
@ 2015-02-24 16:39   ` Hans de Goede
  0 siblings, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2015-02-24 16:39 UTC (permalink / raw)
  To: u-boot

Hi,

On 02/24/2015 03:53 AM, Siarhei Siamashka wrote:
> On Mon, 23 Feb 2015 20:44:10 +0000
> Adam Sampson <ats@offog.org> wrote:
>
>> The tpr3 (timing skew) parameter is used in all supported versions of
>> the sunxi DRAM controller, but it was only enabled for sun4i in
>> 47e3501a76894f4ba08bc61f33774bd5d39ff464.
>>
>> Signed-off-by: Adam Sampson <ats@offog.org>
>> ---
>>   board/sunxi/dram_sun5i_auto.c |    2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/board/sunxi/dram_sun5i_auto.c b/board/sunxi/dram_sun5i_auto.c
>> index e52d54c..660b18e 100644
>> --- a/board/sunxi/dram_sun5i_auto.c
>> +++ b/board/sunxi/dram_sun5i_auto.c
>> @@ -24,7 +24,7 @@ static struct dram_para dram_para = {
>>   #	include "dram_timings_sun4i.h"
>>   	.active_windowing = 1,
>>   #endif
>> -	.tpr3 = 0,
>> +	.tpr3 = CONFIG_DRAM_TPR3,
>>   	.tpr4 = 0,
>>   	.tpr5 = 0,
>>   	.emr1 = CONFIG_DRAM_EMR1,
>
> Oops. Thanks for spotting this.
>
> Acked-by: Siarhei Siamashka <siarhei.siamashka@gmail.com>

Thanks!

Queued up in u-boot-sunxi/next for merging, with Siarhei's ack,

Regards,

Hans

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-02-24 16:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-23 20:44 [U-Boot] [PATCH] sunxi: Make CONFIG_DRAM_TPR3 apply to sun[57]i Adam Sampson
2015-02-24  2:53 ` [U-Boot] [linux-sunxi] " Siarhei Siamashka
2015-02-24 16:39   ` Hans de Goede

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox