From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] usb: common: provide a _weak board_usb_cleanup() function
Date: Tue, 24 Feb 2015 17:05:29 +0100 [thread overview]
Message-ID: <20150224170529.002682bb@amdc2363> (raw)
In-Reply-To: <20150224125606.2cbe25ff@amdc2363>
Hi Lukasz,
> Hi Marek
>
> > This patch implement _weak function for board_usb_cleanup.
> > This function (usb_board_cleanup) implementation is board-specific
> > feature.
> >
> > board_usb_cleanup function can be used to clean up after failed
> > board-specific USB initialization.
> >
> > Signed-off-by: Inha Song <ideal.song@samsung.com>
> > ---
> > common/usb.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/common/usb.c b/common/usb.c
> > index 736cd9f..fbb4495 100644
> > --- a/common/usb.c
> > +++ b/common/usb.c
> > @@ -1063,4 +1063,10 @@ int board_usb_init(int index, enum
> > usb_init_type init) {
> > return 0;
> > }
> > +
> > +__weak
> > +int board_usb_cleanup(int index, enum usb_init_type init)
> > +{
> > + return 0;
> > +}
> > /* EOF */
>
> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>
> Marek could you take this patch (and the following one) to -usb tree?
>
I've looked a bit more deep into this and it seems like this code is
also defined in patches provided by Kishon:
"common: cmd_dfu: invoke board_usb_cleanup() for cleaning up"
b607ea5d62bb0c295f10af86a6de6b33dd1fea75
Marek, it is your call to decide how we should proceed.
My recommendation - we should use Kishon's patches, since it is the
part of a larger patchset.
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
next prev parent reply other threads:[~2015-02-24 16:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 7:07 [U-Boot] [PATCH 0/2] Invoke board specific board_usb_cleanup function Inha Song
2015-01-19 7:07 ` [U-Boot] [PATCH 1/2] usb: common: provide a _weak board_usb_cleanup() function Inha Song
2015-02-24 11:56 ` Lukasz Majewski
2015-02-24 16:05 ` Lukasz Majewski [this message]
2015-02-24 17:34 ` Marek Vasut
2015-02-25 9:15 ` Lukasz Majewski
2015-02-25 17:02 ` Marek Vasut
2015-02-26 8:20 ` Lukasz Majewski
2015-01-19 7:07 ` [U-Boot] [PATCH 2/2] usb: invoke board specific USB cleanup interface Inha Song
2015-02-24 11:56 ` Lukasz Majewski
2015-02-24 16:20 ` Rob Herring
2015-02-25 9:58 ` Inha Song
2015-02-25 13:10 ` Tom Rini
2015-01-19 8:50 ` [U-Boot] [PATCH 0/2] Invoke board specific board_usb_cleanup function Marek Vasut
2015-01-19 9:18 ` Inha Song
2015-01-19 15:02 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150224170529.002682bb@amdc2363 \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox