From: Siarhei Siamashka <siarhei.siamashka@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] added defconfig for Jesurun Q5
Date: Thu, 26 Feb 2015 22:01:37 +0200 [thread overview]
Message-ID: <20150226220137.2c80d2d8@i7> (raw)
In-Reply-To: <1424948895-28764-1-git-send-email-gnyers@opensuse.org>
On Thu, 26 Feb 2015 12:08:15 +0100
G?bor Nyers <gnyers@opensuse.org> wrote:
> The Jesurun Q5 has a black plastic casing with the approximate dimensions of
> 100mm x 100mm x 24mm with rounded edges. In terms of hardware it features an
> Allwinner A10 SoC with 1GB RAM and 8GB of NAND flash. The storage capacity can
> be extended up to 32GB with a MicroSD card. The external connectors are: 2x
> USB-A female supporting USB2.0, 3.5mm female jack for audio, HDMI female,
> SPDIF, RJ45 LAN and Power. In addition the device has 1x red LED (hard wired to
> power) and an programmable green led. On the board there is also an unpopulated
> IR receiver and the UART. The devices is equipped with an AXP209 PMU.
>
> For more details see: http://linux-sunxi.org/Jesurun_Q5
>
> Signed-off-by: G?bor Nyers <gnyers@opensuse.org>
> ---
> configs/jesurun_q5_defconfig | 9 +++++++++
> 1 file changed, 9 insertions(+)
> create mode 100644 configs/jesurun_q5_defconfig
>
> diff --git a/configs/jesurun_q5_defconfig b/configs/jesurun_q5_defconfig
> new file mode 100644
> index 0000000..7ef35f2
> --- /dev/null
> +++ b/configs/jesurun_q5_defconfig
> @@ -0,0 +1,9 @@
> +CONFIG_SPL=y
> +CONFIG_SYS_EXTRA_OPTIONS="AXP209_POWER,SUNXI_EMAC,USB_EHCI,MACPWR=SUNXI_GPH(19)"
> +CONFIG_FDTFILE="sun4i-a10-jesurun-q5.dtb"
> ++S:CONFIG_ARM=y
> ++S:CONFIG_ARCH_SUNXI=y
> ++S:CONFIG_MACH_SUN4I=y
> ++S:CONFIG_DRAM_CLK=312
> ++S:CONFIG_DRAM_ZQ=123
> ++S:CONFIG_DRAM_EMR1=0
This patch is missing the "sunxi:" prefix in the summary line and
also an entry in the "board/sunxi/MAINTAINERS" file.
Additionally, it may be a good idea to have a reference to
the http://linux-sunxi.org/Jesurun_Q5 page as a comment in
the defconfig file. And eventually do the same for all
sunxi defconfigs. Right now the u-boot "configs" directory
is a growing pile of unsorted stuff. And it may be difficult
for a user to decide, which defconfig would be the right one
for his device (considering that some devices are not perfectly
labelled with exactly the same name as the defconfig file).
--
Best regards,
Siarhei Siamashka
next prev parent reply other threads:[~2015-02-26 20:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 23:16 [U-Boot] [PATCH] added defconfig for Jesurun Q5 Gábor Nyers
2015-02-26 8:56 ` Hans de Goede
2015-02-26 11:08 ` Gábor Nyers
2015-02-26 14:33 ` Hans de Goede
2015-02-26 20:01 ` Siarhei Siamashka [this message]
2015-02-27 11:20 ` Ian Campbell
2015-03-02 12:46 ` Hans de Goede
2015-02-26 11:30 ` Gábor Nyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150226220137.2c80d2d8@i7 \
--to=siarhei.siamashka@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox