From mboxrd@z Thu Jan  1 00:00:00 1970
From: Siarhei Siamashka <siarhei.siamashka@gmail.com>
Date: Thu, 26 Feb 2015 22:01:37 +0200
Subject: [U-Boot] [PATCH] added defconfig for Jesurun Q5
In-Reply-To: <1424948895-28764-1-git-send-email-gnyers@opensuse.org>
References: <54EEDFDA.5010504@redhat.com>
 <1424948895-28764-1-git-send-email-gnyers@opensuse.org>
Message-ID: <20150226220137.2c80d2d8@i7>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thu, 26 Feb 2015 12:08:15 +0100
G?bor Nyers <gnyers@opensuse.org> wrote:

> The Jesurun Q5 has a black plastic casing with the approximate dimensions of
> 100mm x 100mm x 24mm with rounded edges. In terms of hardware it features an
> Allwinner A10 SoC with 1GB RAM and 8GB of NAND flash. The storage capacity can
> be extended up to 32GB with a MicroSD card. The external connectors are: 2x
> USB-A female supporting USB2.0, 3.5mm female jack for audio, HDMI female,
> SPDIF, RJ45 LAN and Power. In addition the device has 1x red LED (hard wired to
> power) and an programmable green led. On the board there is also an unpopulated
> IR receiver and the UART. The devices is equipped with an AXP209 PMU.
> 
> For more details see: http://linux-sunxi.org/Jesurun_Q5
> 
> Signed-off-by: G?bor Nyers <gnyers@opensuse.org>
> ---
>  configs/jesurun_q5_defconfig | 9 +++++++++
>  1 file changed, 9 insertions(+)
>  create mode 100644 configs/jesurun_q5_defconfig
> 
> diff --git a/configs/jesurun_q5_defconfig b/configs/jesurun_q5_defconfig
> new file mode 100644
> index 0000000..7ef35f2
> --- /dev/null
> +++ b/configs/jesurun_q5_defconfig
> @@ -0,0 +1,9 @@
> +CONFIG_SPL=y
> +CONFIG_SYS_EXTRA_OPTIONS="AXP209_POWER,SUNXI_EMAC,USB_EHCI,MACPWR=SUNXI_GPH(19)"
> +CONFIG_FDTFILE="sun4i-a10-jesurun-q5.dtb"
> ++S:CONFIG_ARM=y
> ++S:CONFIG_ARCH_SUNXI=y
> ++S:CONFIG_MACH_SUN4I=y
> ++S:CONFIG_DRAM_CLK=312
> ++S:CONFIG_DRAM_ZQ=123
> ++S:CONFIG_DRAM_EMR1=0

This patch is missing the "sunxi:" prefix in the summary line and
also an entry in the "board/sunxi/MAINTAINERS" file.

Additionally, it may be a good idea to have a reference to
the http://linux-sunxi.org/Jesurun_Q5 page as a comment in
the defconfig file. And eventually do the same for all
sunxi defconfigs. Right now the u-boot "configs" directory
is a growing pile of unsorted stuff. And it may be difficult
for a user to decide, which defconfig would be the right one
for his device (considering that some devices are not perfectly
labelled with exactly the same name as the defconfig file).

-- 
Best regards,
Siarhei Siamashka