From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb_storage : scan all interfaces to find a storage device
Date: Tue, 3 Mar 2015 23:28:38 +0100 [thread overview]
Message-ID: <201503032328.38999.marex@denx.de> (raw)
In-Reply-To: <1425417431-2681-1-git-send-email-franck.jullien@gmail.com>
On Tuesday, March 03, 2015 at 10:17:11 PM, franck.jullien at gmail.com wrote:
> From: Franck Jullien <franck.jullien@gmail.com>
>
> Mass storage is not necessary present on interface 0. This
> patch allow usb_stor_scan to look in every available interface.
>
> Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
Hi!
Do you happen to have such a device which isn't present on interface 0?
Also, can you please rework the patch such that level of indentation would
be reasonably low? Possibly by factoring some code into a separate function?
I see that the code already has some really nasty indent and your patch even
adds to that.
Thank you!
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-03-03 22:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 21:17 [U-Boot] [PATCH] usb_storage : scan all interfaces to find a storage device franck.jullien at gmail.com
2015-03-03 22:28 ` Marek Vasut [this message]
2015-03-04 6:34 ` Franck Jullien
2015-03-04 12:36 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201503032328.38999.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox