public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb_storage : scan all interfaces to find a storage device
Date: Wed, 4 Mar 2015 13:36:02 +0100	[thread overview]
Message-ID: <201503041336.02691.marex@denx.de> (raw)
In-Reply-To: <CAJfOKBxO2mrponM71ewQE9vQ=7DLgkKPKgTZcpJCOFaM3wtw4g@mail.gmail.com>

On Wednesday, March 04, 2015 at 07:34:39 AM, Franck Jullien wrote:
> 2015-03-03 23:28 GMT+01:00 Marek Vasut <marex@denx.de>:
> > On Tuesday, March 03, 2015 at 10:17:11 PM, franck.jullien at gmail.com wrote:
> >> From: Franck Jullien <franck.jullien@gmail.com>
> >> 
> >> Mass storage is not necessary present on interface 0. This
> >> patch allow usb_stor_scan to look in every available interface.
> >> 
> >> Signed-off-by: Franck Jullien <franck.jullien@gmail.com>
> > 
> > Hi!
> > 
> > Do you happen to have such a device which isn't present on interface 0?
> > 
> > Also, can you please rework the patch such that level of indentation
> > would be reasonably low? Possibly by factoring some code into a separate
> > function? I see that the code already has some really nasty indent and
> > your patch even adds to that.
> > 
> > Thank you!
> > 
> > Best regards,
> > Marek Vasut
> 
> I do have such a device. However, that's a custom one. For some reasons we
> couldn't put the mass storage device to interface 0.

Is that something custom you cannot even name ? Possibly an FPGA on USB ?

> I was wondering about the level of indentation. You confirmed I need
> to work on it.

Thank _you_ for working on it and keeping up with my ramblings :)

Best regards,
Marek Vasut

      reply	other threads:[~2015-03-04 12:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 21:17 [U-Boot] [PATCH] usb_storage : scan all interfaces to find a storage device franck.jullien at gmail.com
2015-03-03 22:28 ` Marek Vasut
2015-03-04  6:34   ` Franck Jullien
2015-03-04 12:36     ` Marek Vasut [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201503041336.02691.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox