From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 4 Mar 2015 13:36:02 +0100 Subject: [U-Boot] [PATCH] usb_storage : scan all interfaces to find a storage device In-Reply-To: References: <1425417431-2681-1-git-send-email-franck.jullien@gmail.com> <201503032328.38999.marex@denx.de> Message-ID: <201503041336.02691.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday, March 04, 2015 at 07:34:39 AM, Franck Jullien wrote: > 2015-03-03 23:28 GMT+01:00 Marek Vasut : > > On Tuesday, March 03, 2015 at 10:17:11 PM, franck.jullien at gmail.com wrote: > >> From: Franck Jullien > >> > >> Mass storage is not necessary present on interface 0. This > >> patch allow usb_stor_scan to look in every available interface. > >> > >> Signed-off-by: Franck Jullien > > > > Hi! > > > > Do you happen to have such a device which isn't present on interface 0? > > > > Also, can you please rework the patch such that level of indentation > > would be reasonably low? Possibly by factoring some code into a separate > > function? I see that the code already has some really nasty indent and > > your patch even adds to that. > > > > Thank you! > > > > Best regards, > > Marek Vasut > > I do have such a device. However, that's a custom one. For some reasons we > couldn't put the mass storage device to interface 0. Is that something custom you cannot even name ? Possibly an FPGA on USB ? > I was wondering about the level of indentation. You confirmed I need > to work on it. Thank _you_ for working on it and keeping up with my ramblings :) Best regards, Marek Vasut