From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv2 17/20] arm: socfpga: spl: Add SDRAM check
Date: Wed, 4 Mar 2015 14:21:25 +0100 [thread overview]
Message-ID: <201503041421.25863.marex@denx.de> (raw)
In-Reply-To: <1425313688-23595-18-git-send-email-dinguyen@opensource.altera.com>
On Monday, March 02, 2015 at 05:28:05 PM, dinguyen at opensource.altera.com wrote:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> ---
> arch/arm/cpu/armv7/socfpga/spl.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/cpu/armv7/socfpga/spl.c
> b/arch/arm/cpu/armv7/socfpga/spl.c index ea4a1fb..31ac789 100644
> --- a/arch/arm/cpu/armv7/socfpga/spl.c
> +++ b/arch/arm/cpu/armv7/socfpga/spl.c
> @@ -191,4 +191,12 @@ void spl_board_init(void)
>
> sdram_size = sdram_calculate_size();
> debug("SDRAM: %ld MiB\n", (sdram_size >> 20));
> +
> + /* Sanity check ensure correct SDRAM size specified */
> + puts("SDRAM: Ensuring specified SDRAM size is correct ...");
> + if (get_ram_size(0, sdram_size) != sdram_size) {
> + puts("failed\n");
Hi!
Maybe just report a failure, the positive state is not interesting
to the user and just polutes the console with messages which noone
cares about (unless this would be a debug build maybe).
What do you think please ?
> + hang();
> + }
> + puts("passed\n");
> }
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-03-04 13:21 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-02 16:27 [U-Boot] [PATCHv2 00/20] Add SPL support for SoCFPGA dinguyen at opensource.altera.com
2015-03-02 16:27 ` [U-Boot] [PATCHv2 01/20] arm: socfpga: spl: Add main sdram code dinguyen at opensource.altera.com
2015-03-04 19:48 ` Marek Vasut
2015-03-02 16:27 ` [U-Boot] [PATCHv2 02/20] arm: socfpga: spl: Add SRAM section dinguyen at opensource.altera.com
2015-03-04 12:39 ` Marek Vasut
2015-03-04 18:52 ` Dinh Nguyen
2015-03-04 19:39 ` Marek Vasut
2015-03-04 21:34 ` Dinh Nguyen
2015-03-05 20:59 ` Marek Vasut
2015-03-09 21:40 ` Dinh Nguyen
2015-03-02 16:27 ` [U-Boot] [PATCHv2 03/20] arm: socfpga: spl: put SPL in sram dinguyen at opensource.altera.com
2015-03-04 12:40 ` Marek Vasut
2015-03-02 16:27 ` [U-Boot] [PATCHv2 04/20] arm: socfpga: add functions to bring sdram, timer, and uart out of reset dinguyen at opensource.altera.com
2015-03-02 16:27 ` [U-Boot] [PATCHv2 05/20] arm: socfpga: spl: enable sdram, timer and uart dinguyen at opensource.altera.com
2015-03-02 16:27 ` [U-Boot] [PATCHv2 06/20] arm: socfpga: spl: Add call to timer_init dinguyen at opensource.altera.com
2015-03-04 12:42 ` Marek Vasut
2015-03-02 16:27 ` [U-Boot] [PATCHv2 07/20] arm: socfpga: spl: allow bootrom to enable IOs after warm reset dinguyen at opensource.altera.com
2015-03-02 16:27 ` [U-Boot] [PATCHv2 08/20] arm: socfpga: spl: add sdram init and calibration dinguyen at opensource.altera.com
2015-03-04 12:45 ` Marek Vasut
2015-03-02 16:27 ` [U-Boot] [PATCHv2 09/20] arm: socfpga: spl: printout sdram size dinguyen at opensource.altera.com
2015-03-04 12:48 ` Marek Vasut
2015-03-02 16:27 ` [U-Boot] [PATCHv2 10/20] arm: socfpga: spl: Use common lowlevel_init dinguyen at opensource.altera.com
2015-03-04 13:11 ` Marek Vasut
2015-03-02 16:27 ` [U-Boot] [PATCHv2 11/20] arm: socfpga: spl: Add s_init dinguyen at opensource.altera.com
2015-03-02 16:28 ` [U-Boot] [PATCHv2 12/20] arm: socfpga: spl: add the stack in OCRAM dinguyen at opensource.altera.com
2015-03-04 13:14 ` Marek Vasut
2015-03-02 16:28 ` [U-Boot] [PATCHv2 13/20] arm: socfpga: spl: add CONFIG_SPL_STACK to socfpga_common.h dinguyen at opensource.altera.com
2015-03-04 13:14 ` Marek Vasut
2015-03-02 16:28 ` [U-Boot] [PATCHv2 14/20] arm: socfpga: add sdram stack to SPL dinguyen at opensource.altera.com
2015-03-04 13:15 ` Marek Vasut
2015-03-02 16:28 ` [U-Boot] [PATCHv2 15/20] arm: socfpga: spl: adjust SPL_MALLOC_SIZE to 256 dinguyen at opensource.altera.com
2015-03-04 13:16 ` Marek Vasut
2015-03-27 20:10 ` Dinh Nguyen
2015-03-29 23:45 ` Marek Vasut
2015-03-02 16:28 ` [U-Boot] [PATCHv2 16/20] arm: socfpga: spl: add a malloc section in sram dinguyen at opensource.altera.com
2015-03-04 13:19 ` Marek Vasut
2015-03-02 16:28 ` [U-Boot] [PATCHv2 17/20] arm: socfpga: spl: Add SDRAM check dinguyen at opensource.altera.com
2015-03-04 13:21 ` Marek Vasut [this message]
2015-03-09 21:59 ` Dinh Nguyen
2015-03-10 13:39 ` Marek Vasut
2015-03-02 16:28 ` [U-Boot] [PATCHv2 18/20] arm: socfpga: spl: add board_init_f to SPL dinguyen at opensource.altera.com
2015-03-04 13:22 ` Marek Vasut
2015-03-02 16:28 ` [U-Boot] [PATCHv2 19/20] arm: socfpga: spl: update pll_config for dev kit dinguyen at opensource.altera.com
2015-03-04 13:22 ` Marek Vasut
2015-03-02 16:28 ` [U-Boot] [PATCHv2 20/20] arm: socfpga: remove the need to map sdram in arch_early_init dinguyen at opensource.altera.com
2015-03-04 13:22 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201503041421.25863.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox