From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Wed, 4 Mar 2015 14:21:25 +0100 Subject: [U-Boot] [PATCHv2 17/20] arm: socfpga: spl: Add SDRAM check In-Reply-To: <1425313688-23595-18-git-send-email-dinguyen@opensource.altera.com> References: <1425313688-23595-1-git-send-email-dinguyen@opensource.altera.com> <1425313688-23595-18-git-send-email-dinguyen@opensource.altera.com> Message-ID: <201503041421.25863.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Monday, March 02, 2015 at 05:28:05 PM, dinguyen at opensource.altera.com wrote: > From: Dinh Nguyen > > Signed-off-by: Dinh Nguyen > --- > arch/arm/cpu/armv7/socfpga/spl.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/cpu/armv7/socfpga/spl.c > b/arch/arm/cpu/armv7/socfpga/spl.c index ea4a1fb..31ac789 100644 > --- a/arch/arm/cpu/armv7/socfpga/spl.c > +++ b/arch/arm/cpu/armv7/socfpga/spl.c > @@ -191,4 +191,12 @@ void spl_board_init(void) > > sdram_size = sdram_calculate_size(); > debug("SDRAM: %ld MiB\n", (sdram_size >> 20)); > + > + /* Sanity check ensure correct SDRAM size specified */ > + puts("SDRAM: Ensuring specified SDRAM size is correct ..."); > + if (get_ram_size(0, sdram_size) != sdram_size) { > + puts("failed\n"); Hi! Maybe just report a failure, the positive state is not interesting to the user and just polutes the console with messages which noone cares about (unless this would be a debug build maybe). What do you think please ? > + hang(); > + } > + puts("passed\n"); > } Best regards, Marek Vasut