From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v6 4/6] arm: spl: Allow board_init_r() to run with a larger stack
Date: Wed, 4 Mar 2015 17:16:13 -0500 [thread overview]
Message-ID: <20150304221613.GD25373@bill-the-cat> (raw)
In-Reply-To: <1425394982-16196-5-git-send-email-sjg@chromium.org>
On Tue, Mar 03, 2015 at 08:03:00AM -0700, Simon Glass wrote:
> At present SPL uses a single stack, either CONFIG_SPL_STACK or
> CONFIG_SYS_INIT_SP_ADDR. Since some SPL features (such as MMC and
> environment) require a lot of stack, some boards set CONFIG_SPL_STACK to
> point into SDRAM. They then set up SDRAM very early, before board_init_f(),
> so that the larger stack can be used.
>
> This is an abuse of lowlevel_init(). That function should only be used for
> essential start-up code which cannot be delayed. An example of a valid use is
> when only part of the SPL code is visible/executable, and the SoC must be set
> up so that board_init_f() can be reached. It should not be used for SDRAM
> init, console init, etc.
>
> Add a CONFIG_SPL_STACK_R option, which allows the stack to be moved to a new
> address before board_init_r() is called in SPL.
>
> The expected SPL flow (for CONFIG_SPL_FRAMEWORK) is documented in the README.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> For version 1:
> Acked-by: Albert ARIBAUD <albert.u.boot@aribaud.net>
> Reviewed-by: Stefan Roese <sr@denx.de>
> Tested-by: Bo Shen <voice.shen@atmel.com>
> Acked-by: Bo Shen <voice.shen@atmel.com>
> Acked-by: Heiko Schocher <hs@denx.de>
> Tested-by: Heiko Schocher <hs@denx.de>
After fixing the Kconfig part to not have 'CONFIG_' in the 'config' and
'depends' lines, applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150304/ab1e354a/attachment.sig>
next prev parent reply other threads:[~2015-03-04 22:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 15:02 [U-Boot] [PATCH v6 0/6] Clean out SPL and enable driver model Simon Glass
2015-03-03 15:02 ` [U-Boot] [PATCH v6 1/6] arm: Reduce the scope of lowlevel_init() Simon Glass
2015-03-04 22:16 ` Tom Rini
2015-03-03 15:02 ` [U-Boot] [PATCH v6 2/6] arm: spl: Avoid setting up a duplicate global data structure Simon Glass
2015-03-04 22:16 ` Tom Rini
2015-03-03 15:02 ` [U-Boot] [PATCH v6 3/6] dm: tegra: Enable driver model in SPL and adjust the GPIO driver Simon Glass
2015-03-04 22:16 ` Tom Rini
2015-03-08 21:00 ` Stephen Warren
2015-03-09 17:04 ` Simon Glass
2015-03-09 17:23 ` Stephen Warren
2015-03-10 1:15 ` Simon Glass
2015-03-03 15:03 ` [U-Boot] [PATCH v6 4/6] arm: spl: Allow board_init_r() to run with a larger stack Simon Glass
2015-03-03 17:49 ` Tom Rini
2015-03-03 19:04 ` Simon Glass
2015-03-03 20:14 ` Tom Rini
2015-03-04 3:23 ` Simon Glass
2015-03-04 13:38 ` Tom Rini
2015-03-04 15:10 ` Tom Rini
2015-03-04 15:42 ` Tom Rini
2015-03-04 19:14 ` Simon Glass
2015-03-04 22:16 ` Tom Rini [this message]
2015-03-03 15:03 ` [U-Boot] [PATCH v6 5/6] Make export interface support CONFIG_SYS_MALLOC_SIMPLE Simon Glass
2015-03-04 22:16 ` Tom Rini
2015-03-03 15:03 ` [U-Boot] [PATCH v6 6/6] ti: armv7: am33xx: Move SPL SDRAM into the correct place Simon Glass
2015-03-03 15:15 ` Tom Rini
2015-03-03 15:17 ` Simon Glass
2015-03-04 16:30 ` [U-Boot] [PATCH v7 6/6] ti: armv7: Move SPL SDRAM init to the right place, drop unused CONFIG_SPL_STACK Tom Rini
2015-03-04 19:07 ` Simon Glass
2015-03-04 22:16 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150304221613.GD25373@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox