From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] common/board_f: implement type casting for gd structure
Date: Fri, 6 Mar 2015 10:47:28 -0500 [thread overview]
Message-ID: <20150306154728.GD25373@bill-the-cat> (raw)
In-Reply-To: <1424876342-12200-1-git-send-email-abrodkin@synopsys.com>
On Wed, Feb 25, 2015 at 05:59:02PM +0300, Alexey Brodkin wrote:
> In case of global data structure defined as "register volatile" compiler
> throws an warning about incorrect type used:
> --->8---
> common/board_f.c: In function "board_init_f_r":
> common/board_f.c:1073:2: warning: passing argument 1 of "&board_init_r
> +(sizetype)gd->reloc_off" discards "volatile" qualifier from pointer
> target type [enabled by default]
> (board_init_r + gd->reloc_off)(gd, gd->relocaddr);
> ^
> common/board_f.c:1073:2: note: expected "struct gd_t *" but argument is
> of type "volatile struct gd_t *"
> --->8---
>
> An obvious fix is manual casting to "gd_t *".
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@ti.com>
> Acked-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150306/3bfee7e2/attachment.sig>
prev parent reply other threads:[~2015-03-06 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 14:59 [U-Boot] [PATCH] common/board_f: implement type casting for gd structure Alexey Brodkin
2015-03-02 16:03 ` Simon Glass
2015-03-06 15:47 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150306154728.GD25373@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox