From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 1/2] usb: dwc2: fix aligned buffer usage
Date: Mon, 9 Mar 2015 13:46:21 +0100 [thread overview]
Message-ID: <201503091346.21794.marex@denx.de> (raw)
In-Reply-To: <1425834494-24649-1-git-send-email-swarren@wwwdotorg.org>
On Sunday, March 08, 2015 at 06:08:13 PM, Stephen Warren wrote:
> The original aligned_buffer usage:
> a) Uselessly copied data into the aligned buffer even for IN
> transactions. Fix this my making the copy conditional.
> b) Always programmed the HW to transfer to/from the start of the aligned
> buffer. This worked fine for OUT transactions since the memcpy copied
> the OUT data to this location too. However, for large IN transactions,
> since the copy from the aligned buffer to the "client" buffer was
> deferred until after all chunks were transferred. it resulted in each
> chunk's transfer over-writing the data for the first transfer. Fix
> this by copying IN data as soon as it's received.
>
> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
Applied to u-boot-usb/topic/dwc2, thanks. I would like to see more
testing from others if possible, otherwise this will go in after
2015.04 if you're fine with that.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-03-09 12:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 17:08 [U-Boot] [PATCH V2 1/2] usb: dwc2: fix aligned buffer usage Stephen Warren
2015-03-08 17:08 ` [U-Boot] [PATCH V2 2/2] usb: dwc2: remove restriction on buffer length Stephen Warren
2015-03-09 12:46 ` Marek Vasut [this message]
2015-03-09 16:33 ` [U-Boot] [PATCH V2 1/2] usb: dwc2: fix aligned buffer usage Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201503091346.21794.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox