public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mmc: fsl_esdhc fix register offset
Date: Wed, 11 Mar 2015 13:46:44 -0400	[thread overview]
Message-ID: <20150311174644.GU32541@bill-the-cat> (raw)
In-Reply-To: <CAOMZO5DL4KV18D0ETcSd7GHGWMyUtbD5Cam4kuTcaVW9cCp43A@mail.gmail.com>

On Wed, Mar 11, 2015 at 01:03:16PM -0300, Fabio Estevam wrote:
> On Wed, Mar 11, 2015 at 10:55 AM, Pantelis Antoniou
> <panto@antoniou-consulting.com> wrote:
> 
> > Although I agree with fixing this, I?m kinda scared about how fragile
> > structs for describing hardware registers are.
> 
> Agreed!
> 
> > But we?re stuck with it I guess.
> 
> Yes, it seems this is mandatory in U-boot.
> 
> Kernel does not have such requirement and the standard way there is to
> use (base + offset) for register accesses.

So this is one of those topics that long term, I'd like to change U-Boot
for but it's both a giant change and something we need to do a lot of
prep-work for still.  The long ago argument for why U-Boot does things
the way it does boils down to type checking.  The kernel gets this I
think with a combination of sparse and other preprocessor magic /
checks.

We'll also need to migrate once device model work is farther along and
people want more seriously to look at splitting out a runs-many-places
U-Boot from a "must be board-centric, pretty much" SPL.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150311/7bfdda41/attachment.sig>

  reply	other threads:[~2015-03-11 17:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10  7:35 [U-Boot] [PATCH] mmc: fsl_esdhc fix register offset Peng Fan
2015-03-10 13:45 ` Marek Vasut
2015-03-11  0:58   ` Peng Fan
2015-03-11  2:03     ` Marek Vasut
2015-03-11  2:17       ` Peng Fan
2015-03-11 11:29         ` Marek Vasut
2015-03-11 13:55         ` Pantelis Antoniou
2015-03-11 14:00           ` Joakim Tjernlund
2015-03-11 16:03           ` Fabio Estevam
2015-03-11 17:46             ` Tom Rini [this message]
2015-03-11 13:00 ` Fabio Estevam
2015-03-15  5:54   ` Peng Fan
2015-03-15 14:28     ` Marek Vasut
2015-03-15 16:39     ` Joakim Tjernlund
2015-03-17 13:10 ` [U-Boot] " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150311174644.GU32541@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox