public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 1/4] ARM: DRA7XX: Add config file for Android with fastboot support
Date: Thu, 12 Mar 2015 15:29:02 -0400	[thread overview]
Message-ID: <20150312192902.GD32541@bill-the-cat> (raw)
In-Reply-To: <CAL6W151RenVUpxZkOwzuAQV6_3yVqSQNdSP749J8Mp9GaH-wYQ@mail.gmail.com>

On Thu, Mar 12, 2015 at 12:01:15PM +0530, Dileep Katta wrote:
> Hi Tom and Lukasz,
> 
> On 4 March 2015 at 22:22, Tom Rini <trini@konsulko.com> wrote:
> 
> > On Tue, Mar 03, 2015 at 04:40:41PM +0530, Dileep Katta wrote:
> >
> > > Signed-off-by: Angela Stegmaier <angelabaker@ti.com>
> > > Signed-off-by: Dileep Katta <dileep.katta@linaro.org>
> > > ---
> > >  arch/arm/cpu/armv7/omap5/Kconfig     |   5 +
> > >  board/ti/dra7xx/Kconfig              |  13 ++
> > >  board/ti/dra7xx/MAINTAINERS          |   2 +
> > >  configs/dra7xx_evm_android_defconfig |   5 +
> > >  include/configs/dra7xx_evm_android.h | 313
> > +++++++++++++++++++++++++++++++++++
> > >  5 files changed, 338 insertions(+)
> > >  create mode 100644 configs/dra7xx_evm_android_defconfig
> > >  create mode 100644 include/configs/dra7xx_evm_android.h
> >
> > I _really_ don't like how we're duplicating large hunks of dra7xx_evm.h.
> > The first question is, what parts of this are not appropriate to just do
> > in dra7xx_evm.h directly?  And the second question would be, which of
> > those cannot simply be done via Kconfig choices.
>
> Discussed this with Angela from TI, and arrived at a common header file so
> that the duplication could be avoided. Will send a follow-up patch with the
> update.

Note that I'm still skeptical that there's things that can't just be
Kconfig choices and the rest just be in dra7xx_evm.h.  Sort out and come
up with a common flash/etc layout and so forth.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150312/ed8fe5c6/attachment.sig>

  reply	other threads:[~2015-03-12 19:29 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 11:10 [U-Boot] [PATCH v1 1/4] ARM: DRA7XX: Add config file for Android with fastboot support Dileep Katta
2015-03-03 11:10 ` [U-Boot] [PATCH v2 2/4] fastboot: call board_usb_init() to enable usb Dileep Katta
2015-03-04 13:19   ` Lukasz Majewski
2015-03-04 17:05   ` Stegmaier, Angela
2015-03-04 18:29     ` Tom Rini
2015-03-04 19:06       ` Dileep Katta
2015-03-05 14:37         ` Tom Rini
2015-03-12  6:36           ` Dileep Katta
2015-03-12  8:55             ` Lukasz Majewski
2015-03-12 17:28               ` Marek Vasut
2015-03-12 21:12                 ` Dileep Katta
2015-03-13  7:53                   ` Lukasz Majewski
2015-03-13 19:28                     ` Dileep Katta
2015-03-13 20:55                       ` Lukasz Majewski
2015-03-27 17:53                         ` Dileep Katta
2015-03-27 18:15                           ` Tom Rini
2015-03-27 18:25                             ` Marek Vasut
2015-03-30  8:38                               ` Lukasz Majewski
2015-03-03 11:10 ` [U-Boot] [PATCH v3 3/4] ARM: DRA7: Set serial number environment variable Dileep Katta
2015-03-04 13:23   ` Lukasz Majewski
2015-03-04 16:53   ` Tom Rini
2015-03-07  7:00   ` Nishanth Menon
2015-03-03 11:10 ` [U-Boot] [PATCH v1 4/4] ARM: DRA7: fastboot: Implement reboot-bootloader command - Implemented fb_set_reboot_flag() for DRA7 - Defined a weak function, fb_check_reboot_flag() - Implemented for DRA7 Dileep Katta
2015-03-03 14:15   ` Rob Herring
2015-03-04 16:57     ` Tom Rini
2015-03-04 13:31   ` Lukasz Majewski
2015-03-03 11:53 ` [U-Boot] [PATCH v1 1/4] ARM: DRA7XX: Add config file for Android with fastboot support Dileep Katta
2015-03-04 13:18 ` Lukasz Majewski
2015-03-04 16:52 ` Tom Rini
2015-03-12  6:31   ` Dileep Katta
2015-03-12 19:29     ` Tom Rini [this message]
2015-03-17 18:38       ` [U-Boot] [PATCH v2 1/1] " Dileep Katta
2015-03-18 16:11         ` Tom Rini
2015-03-18 21:12           ` Dileep Katta
2015-03-19 13:15             ` Tom Rini
2015-03-23 22:41               ` Dileep Katta
2015-03-24 22:34                 ` [U-Boot] [PATCH v3 1/3] ARM: DRA7XX: Enable Fastboot Dileep Katta
2015-03-24 22:34                   ` [U-Boot] [PATCH v3 2/3] ARM: DRA7: Set serial number environment variable Dileep Katta
2015-03-27 14:19                     ` Tom Rini
2015-04-23 22:03                     ` [U-Boot] [U-Boot, v3, " Tom Rini
2015-03-24 22:34                   ` [U-Boot] [PATCH v3 3/3] fastboot: ARM: OMAP5: Enable reboot-bootloader Dileep Katta
2015-03-27 14:19                     ` Tom Rini
2015-03-27 17:28                       ` Dileep Katta
2015-03-27 17:36                         ` [U-Boot] [PATCH v4 " Dileep Katta
2015-03-27 18:02                           ` Tom Rini
2015-04-23 22:03                           ` [U-Boot] [U-Boot, v4, " Tom Rini
2015-03-27 14:19                   ` [U-Boot] [PATCH v3 1/3] ARM: DRA7XX: Enable Fastboot Tom Rini
2015-04-23 22:03                   ` [U-Boot] [U-Boot,v3,1/3] " Tom Rini
2015-03-23  8:50         ` [U-Boot] [PATCH v2 1/1] ARM: DRA7XX: Add config file for Android with fastboot support Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150312192902.GD32541@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox