public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/4] fastboot: call board_usb_init() to enable usb
Date: Fri, 13 Mar 2015 08:53:03 +0100	[thread overview]
Message-ID: <20150313085303.094f4be7@amdc2363> (raw)
In-Reply-To: <1426194750-15213-1-git-send-email-dileep.katta@linaro.org>

Hi Dileep,

> g_dnl_gadget_register() fails for dra7xx dwc3 gadget when running
> cmd_fastboot. Calling board_usb_init() to fix this.
> fastboot command is now added with an optional controller index
> argument with default value as 0, to facilitate configurable
> controller index.
> 
> Signed-off-by: Angela Stegmaier <angelabaker@ti.com>
> Signed-off-by: Dileep Katta <dileep.katta@linaro.org>
> ---
> Changes in v2:
> 	- Changed fastboot command to facilitate passing controller
> index
> 	- Added board_usb_cleanup()
> This patch considers the following change by Inha Song, without which
> the build will be broken on BeagleBone Black platform
> 	https://patchwork.ozlabs.org/patch/430303/
> 	
>  common/cmd_fastboot.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c
> index 346ab80..9ca4a2f 100644
> --- a/common/cmd_fastboot.c
> +++ b/common/cmd_fastboot.c
> @@ -10,11 +10,19 @@
>  #include <common.h>
>  #include <command.h>
>  #include <g_dnl.h>
> +#include <usb.h>
>  
>  static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char
> *const argv[]) {
>  	int ret;
> +	int controller_index = 0;
>  
> +	if (argc == 2) {
> +		char *usb_controller = argv[1];
> +		controller_index = simple_strtoul(usb_controller,
> NULL, 0);
> +	}
> +
> +	board_usb_init(controller_index, USB_INIT_DEVICE);
>  	g_dnl_clear_detach();
>  	ret = g_dnl_register("usb_dnl_fastboot");
>  	if (ret)
> @@ -36,12 +44,13 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int
> flag, int argc, char *const argv[]) 
>  	g_dnl_unregister();
>  	g_dnl_clear_detach();
> +	board_usb_cleanup(controller_index, USB_INIT_DEVICE);
>  	return CMD_RET_SUCCESS;
>  }
>  
>  U_BOOT_CMD(
> -	fastboot,	1,	0,	do_fastboot,
> +	fastboot,	2,	0,	do_fastboot,
>  	"use USB Fastboot protocol",
> -	"\nLukasz Majewski <l.majewski@samsung.com>"
> -	"    - run as a fastboot usb device"
> +	"[<USB_controller>]\n"
> +	"    - run as a fastboot usb device via <USB_controller>"
>  );

Acked-by: Lukasz Majewski <l.majewski@samsung.com>

Since I'm not CC'ed to all patches, I assume that this work would go
via other tree?

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

  reply	other threads:[~2015-03-13  7:53 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-03 11:10 [U-Boot] [PATCH v1 1/4] ARM: DRA7XX: Add config file for Android with fastboot support Dileep Katta
2015-03-03 11:10 ` [U-Boot] [PATCH v2 2/4] fastboot: call board_usb_init() to enable usb Dileep Katta
2015-03-04 13:19   ` Lukasz Majewski
2015-03-04 17:05   ` Stegmaier, Angela
2015-03-04 18:29     ` Tom Rini
2015-03-04 19:06       ` Dileep Katta
2015-03-05 14:37         ` Tom Rini
2015-03-12  6:36           ` Dileep Katta
2015-03-12  8:55             ` Lukasz Majewski
2015-03-12 17:28               ` Marek Vasut
2015-03-12 21:12                 ` Dileep Katta
2015-03-13  7:53                   ` Lukasz Majewski [this message]
2015-03-13 19:28                     ` Dileep Katta
2015-03-13 20:55                       ` Lukasz Majewski
2015-03-27 17:53                         ` Dileep Katta
2015-03-27 18:15                           ` Tom Rini
2015-03-27 18:25                             ` Marek Vasut
2015-03-30  8:38                               ` Lukasz Majewski
2015-03-03 11:10 ` [U-Boot] [PATCH v3 3/4] ARM: DRA7: Set serial number environment variable Dileep Katta
2015-03-04 13:23   ` Lukasz Majewski
2015-03-04 16:53   ` Tom Rini
2015-03-07  7:00   ` Nishanth Menon
2015-03-03 11:10 ` [U-Boot] [PATCH v1 4/4] ARM: DRA7: fastboot: Implement reboot-bootloader command - Implemented fb_set_reboot_flag() for DRA7 - Defined a weak function, fb_check_reboot_flag() - Implemented for DRA7 Dileep Katta
2015-03-03 14:15   ` Rob Herring
2015-03-04 16:57     ` Tom Rini
2015-03-04 13:31   ` Lukasz Majewski
2015-03-03 11:53 ` [U-Boot] [PATCH v1 1/4] ARM: DRA7XX: Add config file for Android with fastboot support Dileep Katta
2015-03-04 13:18 ` Lukasz Majewski
2015-03-04 16:52 ` Tom Rini
2015-03-12  6:31   ` Dileep Katta
2015-03-12 19:29     ` Tom Rini
2015-03-17 18:38       ` [U-Boot] [PATCH v2 1/1] " Dileep Katta
2015-03-18 16:11         ` Tom Rini
2015-03-18 21:12           ` Dileep Katta
2015-03-19 13:15             ` Tom Rini
2015-03-23 22:41               ` Dileep Katta
2015-03-24 22:34                 ` [U-Boot] [PATCH v3 1/3] ARM: DRA7XX: Enable Fastboot Dileep Katta
2015-03-24 22:34                   ` [U-Boot] [PATCH v3 2/3] ARM: DRA7: Set serial number environment variable Dileep Katta
2015-03-27 14:19                     ` Tom Rini
2015-04-23 22:03                     ` [U-Boot] [U-Boot, v3, " Tom Rini
2015-03-24 22:34                   ` [U-Boot] [PATCH v3 3/3] fastboot: ARM: OMAP5: Enable reboot-bootloader Dileep Katta
2015-03-27 14:19                     ` Tom Rini
2015-03-27 17:28                       ` Dileep Katta
2015-03-27 17:36                         ` [U-Boot] [PATCH v4 " Dileep Katta
2015-03-27 18:02                           ` Tom Rini
2015-04-23 22:03                           ` [U-Boot] [U-Boot, v4, " Tom Rini
2015-03-27 14:19                   ` [U-Boot] [PATCH v3 1/3] ARM: DRA7XX: Enable Fastboot Tom Rini
2015-04-23 22:03                   ` [U-Boot] [U-Boot,v3,1/3] " Tom Rini
2015-03-23  8:50         ` [U-Boot] [PATCH v2 1/1] ARM: DRA7XX: Add config file for Android with fastboot support Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150313085303.094f4be7@amdc2363 \
    --to=l.majewski@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox