public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] bootcount: Add dcache flush to bootcount_store()
Date: Mon, 16 Mar 2015 13:22:42 -0400	[thread overview]
Message-ID: <20150316172242.GD32541@bill-the-cat> (raw)
In-Reply-To: <55070EB5.7070604@freescale.com>

On Mon, Mar 16, 2015 at 10:11:17AM -0700, York Sun wrote:
> 
> 
> On 03/16/2015 10:05 AM, Tom Rini wrote:
> >>>> 8xx and 83xx just need the dummy files copied over.
> >>>
> >>> OK, I went and poked at going one direction on this and then dug into
> >>> the higher level problem more.  PowerPC _needs_ the current kernel's
> >>> arch/powerpc/kernel/misc_32.S relevant cache functions ported over for
> >>> everyone and we should kill the dummy functions we have today.  To try
> >>> and encourage some folks to do this I'm going to drop this bootcount
> >>> patch for now.
> >>>
> >>
> >> FWIW, powerpc mpc83xx, mpc85xx, mpc86xx all have flush_dcache_range() function
> >> defined.
> > 
> > Yes and no:
> > $ git grep -l flush_dcache_range arch/powerpc/
> > arch/powerpc/cpu/mpc512x/cache.c
> > arch/powerpc/cpu/mpc5xxx/cache.c
> > arch/powerpc/cpu/mpc83xx/cache.c
> > arch/powerpc/cpu/mpc85xx/cache.c
> > arch/powerpc/cpu/mpc86xx/cache.S
> > arch/powerpc/cpu/ppc4xx/cache.S
> > 
> > Of these only ppc4xx and mpc86xx are real functions, borrowed from the
> > kernel long long ago.  The rest are dummy functions.  And we should
> > instead make everyone have the same real functions the kernel does :)
> 
> Ah! I was under the impression we use it. But we actually used flush_cache()
> function.

Yeah, there's some related cleanup that should be done too :)

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150316/29f32fa5/attachment.sig>

  reply	other threads:[~2015-03-16 17:22 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-11  8:51 [U-Boot] [PATCH] autoboot.c: Add feature to stop autobooting via SHA256 encrypted password Stefan Roese
2015-03-11  8:51 ` [U-Boot] [PATCH] bootcount: Add dcache flush to bootcount_store() Stefan Roese
2015-03-11 14:39   ` Tom Rini
2015-03-13 13:48   ` [U-Boot] " Tom Rini
2015-03-13 14:34     ` Tom Rini
2015-03-15 18:30       ` Tom Rini
2015-03-16 15:57         ` York Sun
2015-03-16 17:05           ` Tom Rini
2015-03-16 17:11             ` York Sun
2015-03-16 17:22               ` Tom Rini [this message]
2015-03-17  9:00       ` Holger Brunck
2015-03-27 13:18         ` Stefan Roese
2015-03-27 13:42           ` Nitin Garg
2015-03-27 15:07             ` [U-Boot] [RFC] powerpc: add 2 common dcache assembly functions Valentin Longchamp
2015-03-28 18:07               ` Tom Rini
2015-05-05 16:35               ` [U-Boot] [U-Boot, RFC] " York Sun
2015-03-11  8:51 ` [U-Boot] [PATCH] cmd_led: Extend led command to support blinking and more leds Stefan Roese
2015-03-11 14:38   ` Tom Rini
2015-04-23 22:02   ` [U-Boot] " Tom Rini
2015-03-11  8:51 ` [U-Boot] [PATCH] misc: led: Add PCA9551 LED driver Stefan Roese
2015-03-11 14:40   ` Tom Rini
2015-03-11 14:46   ` Fabio Estevam
2015-03-11 14:36 ` [U-Boot] [PATCH] autoboot.c: Add feature to stop autobooting via SHA256 encrypted password Tom Rini
2015-03-12  8:39   ` Stefan Roese
2015-03-13  2:48   ` Simon Glass
2015-03-13  7:15     ` Stefan Roese
2015-03-23 20:28       ` Simon Glass
2015-05-05 15:06         ` Stefan Roese
2015-05-05 15:12           ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150316172242.GD32541@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox