[U-Boot] bav335x support broken

Gilles
2015-03-14T05:06:51Z

Folks,

I posted a patch to add support for bav335x boards (a322aad99de4). The patch was tested against v2015.04-rc1 and worked perfectly but somehow, something was introduced since then which breaks the board support.

There are two main errors I need to fix before posting another patch but need help with the second error.

The first error is easy. Compilation throws:
#error "Please define NS16550 registers size."
which I can simply fix by defining CONFIG_SYS_NS16550_REG_SIZE in include/configs/bav335x.h
((( Altough I am stil puzzled as to why this was defined as -4 (where?) on v2015.04-rc1 )))

After adding the define, everything compiles up to failing on the final link with:

drivers/serial/built-in.o: In function `get_current':
/home/gilles/bbdev/u-boot/drivers/serial/serial.c:389: undefined reference to `default_serial_console'
drivers/serial/built-in.o: In function `serial_initialize':

Can anyone please explain what changed between 2015.04-rc1 and 2015.04-rc2 which could cause such a behavior? I have spent the last couple hours re-basing a branch to see where it breaks as to maybe get a clue on what changed but no luck so far. Any tips would be appreciated.

Thanks,
Gilles
.