From: Lukasz Majewski <l.majewski@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dfu: cmd: trigger watchdog before calling usb_gadget_handle_interrupts
Date: Tue, 17 Mar 2015 10:52:02 +0100 [thread overview]
Message-ID: <20150317105202.3ec3d070@amdc2363> (raw)
In-Reply-To: <1426170850-25688-1-git-send-email-hs@denx.de>
Hi Heiko,
> trigger watchdog before calling usb_gadget_handle_interrupts()
> This prevents board resets when calling dfu command on boards
> which have a watchdog.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
>
> common/cmd_dfu.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/common/cmd_dfu.c b/common/cmd_dfu.c
> index e975abe..46af4cf 100644
> --- a/common/cmd_dfu.c
> +++ b/common/cmd_dfu.c
> @@ -9,6 +9,7 @@
> */
>
> #include <common.h>
> +#include <watchdog.h>
> #include <dfu.h>
> #include <g_dnl.h>
> #include <usb.h>
> @@ -64,6 +65,7 @@ static int do_dfu(cmd_tbl_t *cmdtp, int flag, int
> argc, char * const argv[]) if (ctrlc())
> goto exit;
>
> + WATCHDOG_RESET();
> usb_gadget_handle_interrupts();
> }
> exit:
It seems strange for me, that we must reset watchdog when looping in
the dfu.
What is the WATCHDOG interval on the affected board?
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
next prev parent reply other threads:[~2015-03-17 9:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 14:34 [U-Boot] [PATCH] dfu: cmd: trigger watchdog before calling usb_gadget_handle_interrupts Heiko Schocher
2015-03-17 9:52 ` Lukasz Majewski [this message]
2015-03-17 10:48 ` Heiko Schocher
2015-03-17 12:56 ` Lukasz Majewski
2015-03-17 13:27 ` Heiko Schocher
2015-03-17 15:16 ` Lukasz Majewski
2015-03-17 16:09 ` Tom Rini
2015-03-17 21:36 ` Lukasz Majewski
2015-03-18 6:32 ` Heiko Schocher
2015-03-18 7:44 ` Lukasz Majewski
2015-03-18 8:10 ` Heiko Schocher
2015-03-19 11:11 ` Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317105202.3ec3d070@amdc2363 \
--to=l.majewski@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox