* [U-Boot] [PATCH] dm: serial: remove bogus include <ns16550.h>
@ 2015-03-20 4:24 Masahiro Yamada
2015-03-20 15:24 ` Tom Rini
0 siblings, 1 reply; 4+ messages in thread
From: Masahiro Yamada @ 2015-03-20 4:24 UTC (permalink / raw)
To: u-boot
Serial-uclass should be generically implemented without depending
a particular hardware. Fortunately, nothing in include/ns16550.h is
referenced from drivers/serial/serial-uclass.c, so remove this bogus
include.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/serial/serial-uclass.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/serial/serial-uclass.c b/drivers/serial/serial-uclass.c
index 3fc7104..2de3737 100644
--- a/drivers/serial/serial-uclass.c
+++ b/drivers/serial/serial-uclass.c
@@ -16,8 +16,6 @@
#include <dm/lists.h>
#include <dm/device-internal.h>
-#include <ns16550.h>
-
DECLARE_GLOBAL_DATA_PTR;
/*
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] dm: serial: remove bogus include <ns16550.h>
2015-03-20 4:24 [U-Boot] [PATCH] dm: serial: remove bogus include <ns16550.h> Masahiro Yamada
@ 2015-03-20 15:24 ` Tom Rini
2015-03-20 23:52 ` Simon Glass
0 siblings, 1 reply; 4+ messages in thread
From: Tom Rini @ 2015-03-20 15:24 UTC (permalink / raw)
To: u-boot
On Fri, Mar 20, 2015 at 01:24:45PM +0900, Masahiro Yamada wrote:
> Serial-uclass should be generically implemented without depending
> a particular hardware. Fortunately, nothing in include/ns16550.h is
> referenced from drivers/serial/serial-uclass.c, so remove this bogus
> include.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150320/fdc59133/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] dm: serial: remove bogus include <ns16550.h>
2015-03-20 15:24 ` Tom Rini
@ 2015-03-20 23:52 ` Simon Glass
2015-03-25 22:45 ` Simon Glass
0 siblings, 1 reply; 4+ messages in thread
From: Simon Glass @ 2015-03-20 23:52 UTC (permalink / raw)
To: u-boot
On 20 March 2015 at 09:24, Tom Rini <trini@konsulko.com> wrote:
> On Fri, Mar 20, 2015 at 01:24:45PM +0900, Masahiro Yamada wrote:
>
>> Serial-uclass should be generically implemented without depending
>> a particular hardware. Fortunately, nothing in include/ns16550.h is
>> referenced from drivers/serial/serial-uclass.c, so remove this bogus
>> include.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Acked-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] dm: serial: remove bogus include <ns16550.h>
2015-03-20 23:52 ` Simon Glass
@ 2015-03-25 22:45 ` Simon Glass
0 siblings, 0 replies; 4+ messages in thread
From: Simon Glass @ 2015-03-25 22:45 UTC (permalink / raw)
To: u-boot
On 20 March 2015 at 17:52, Simon Glass <sjg@chromium.org> wrote:
> On 20 March 2015 at 09:24, Tom Rini <trini@konsulko.com> wrote:
>> On Fri, Mar 20, 2015 at 01:24:45PM +0900, Masahiro Yamada wrote:
>>
>>> Serial-uclass should be generically implemented without depending
>>> a particular hardware. Fortunately, nothing in include/ns16550.h is
>>> referenced from drivers/serial/serial-uclass.c, so remove this bogus
>>> include.
>>>
>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>
>> Reviewed-by: Tom Rini <trini@konsulko.com>
>
> Acked-by: Simon Glass <sjg@chromium.org>
Applied to u-boot-dm, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-25 22:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-20 4:24 [U-Boot] [PATCH] dm: serial: remove bogus include <ns16550.h> Masahiro Yamada
2015-03-20 15:24 ` Tom Rini
2015-03-20 23:52 ` Simon Glass
2015-03-25 22:45 ` Simon Glass
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox