* [U-Boot] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing
@ 2015-03-15 17:28 Paul Kocialkowski
2015-03-15 18:12 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Paul Kocialkowski @ 2015-03-15 17:28 UTC (permalink / raw)
To: u-boot
Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
---
common/cmd_fastboot.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c
index 346ab80..7956a5b 100644
--- a/common/cmd_fastboot.c
+++ b/common/cmd_fastboot.c
@@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
if (!g_dnl_board_usb_cable_connected()) {
puts("\rUSB cable not detected.\n" \
"Command exit.\n");
+ g_dnl_unregister();
+ g_dnl_clear_detach();
return CMD_RET_FAILURE;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing
2015-03-15 17:28 [U-Boot] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing Paul Kocialkowski
@ 2015-03-15 18:12 ` Marek Vasut
2015-03-22 12:05 ` Paul Kocialkowski
0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2015-03-15 18:12 UTC (permalink / raw)
To: u-boot
On Sunday, March 15, 2015 at 06:28:35 PM, Paul Kocialkowski wrote:
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
> common/cmd_fastboot.c | 2 ++
> 1 file changed, 2 insertions(+)
+CC Lukasz and Steve.
> diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c
> index 346ab80..7956a5b 100644
> --- a/common/cmd_fastboot.c
> +++ b/common/cmd_fastboot.c
> @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int
> argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected()) {
> puts("\rUSB cable not detected.\n" \
> "Command exit.\n");
> + g_dnl_unregister();
> + g_dnl_clear_detach();
> return CMD_RET_FAILURE;
> }
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing
2015-03-15 18:12 ` Marek Vasut
@ 2015-03-22 12:05 ` Paul Kocialkowski
2015-03-22 12:24 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Paul Kocialkowski @ 2015-03-22 12:05 UTC (permalink / raw)
To: u-boot
Hi,
Le dimanche 15 mars 2015 ? 19:12 +0100, Marek Vasut a ?crit :
> On Sunday, March 15, 2015 at 06:28:35 PM, Paul Kocialkowski wrote:
> > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > ---
> > common/cmd_fastboot.c | 2 ++
> > 1 file changed, 2 insertions(+)
>
> +CC Lukasz and Steve.
Is there anything holding back that patch at this point?
> > diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c
> > index 346ab80..7956a5b 100644
> > --- a/common/cmd_fastboot.c
> > +++ b/common/cmd_fastboot.c
> > @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int
> > argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected()) {
> > puts("\rUSB cable not detected.\n" \
> > "Command exit.\n");
> > + g_dnl_unregister();
> > + g_dnl_clear_detach();
> > return CMD_RET_FAILURE;
> > }
>
> Best regards,
> Marek Vasut
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150322/c1b0d88a/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing
2015-03-22 12:05 ` Paul Kocialkowski
@ 2015-03-22 12:24 ` Marek Vasut
2015-03-22 13:18 ` Paul Kocialkowski
0 siblings, 1 reply; 6+ messages in thread
From: Marek Vasut @ 2015-03-22 12:24 UTC (permalink / raw)
To: u-boot
On Sunday, March 22, 2015 at 01:05:14 PM, Paul Kocialkowski wrote:
> Hi,
>
> Le dimanche 15 mars 2015 ? 19:12 +0100, Marek Vasut a ?crit :
> > On Sunday, March 15, 2015 at 06:28:35 PM, Paul Kocialkowski wrote:
> > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > > ---
> > >
> > > common/cmd_fastboot.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> >
> > +CC Lukasz and Steve.
>
> Is there anything holding back that patch at this point?
Hi
Lukasz is the USB gadget side maintainer, so please wait for him to pick this.
Thanks
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing
2015-03-22 12:24 ` Marek Vasut
@ 2015-03-22 13:18 ` Paul Kocialkowski
2015-03-22 16:46 ` Marek Vasut
0 siblings, 1 reply; 6+ messages in thread
From: Paul Kocialkowski @ 2015-03-22 13:18 UTC (permalink / raw)
To: u-boot
Le dimanche 22 mars 2015 ? 13:24 +0100, Marek Vasut a ?crit :
> On Sunday, March 22, 2015 at 01:05:14 PM, Paul Kocialkowski wrote:
> > Hi,
> >
> > Le dimanche 15 mars 2015 ? 19:12 +0100, Marek Vasut a ?crit :
> > > On Sunday, March 15, 2015 at 06:28:35 PM, Paul Kocialkowski wrote:
> > > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > > > ---
> > > >
> > > > common/cmd_fastboot.c | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > >
> > > +CC Lukasz and Steve.
> >
> > Is there anything holding back that patch at this point?
>
> Hi
>
> Lukasz is the USB gadget side maintainer, so please wait for him to
> pick this.
Oh okay, I thought it was up to you, my mistake.
--
Paul Kocialkowski, Replicant developer
Replicant is a fully free Android distribution running on several
devices, a free software mobile operating system putting the emphasis on
freedom and privacy/security.
Website: http://www.replicant.us/
Blog: http://blog.replicant.us/
Wiki/tracker/forums: http://redmine.replicant.us/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150322/d0615c5b/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing
2015-03-22 13:18 ` Paul Kocialkowski
@ 2015-03-22 16:46 ` Marek Vasut
0 siblings, 0 replies; 6+ messages in thread
From: Marek Vasut @ 2015-03-22 16:46 UTC (permalink / raw)
To: u-boot
On Sunday, March 22, 2015 at 02:18:09 PM, Paul Kocialkowski wrote:
> Le dimanche 22 mars 2015 ? 13:24 +0100, Marek Vasut a ?crit :
> > On Sunday, March 22, 2015 at 01:05:14 PM, Paul Kocialkowski wrote:
> > > Hi,
> > >
> > > Le dimanche 15 mars 2015 ? 19:12 +0100, Marek Vasut a ?crit :
> > > > On Sunday, March 15, 2015 at 06:28:35 PM, Paul Kocialkowski wrote:
> > > > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > > > > ---
> > > > >
> > > > > common/cmd_fastboot.c | 2 ++
> > > > > 1 file changed, 2 insertions(+)
> > > >
> > > > +CC Lukasz and Steve.
> > >
> > > Is there anything holding back that patch at this point?
> >
> > Hi
> >
> > Lukasz is the USB gadget side maintainer, so please wait for him to
> > pick this.
>
> Oh okay, I thought it was up to you, my mistake.
I can pick them in case Lukasz is inactive for too long, give it a week
and ping me again in such case please.
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-22 16:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-15 17:28 [U-Boot] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing Paul Kocialkowski
2015-03-15 18:12 ` Marek Vasut
2015-03-22 12:05 ` Paul Kocialkowski
2015-03-22 12:24 ` Marek Vasut
2015-03-22 13:18 ` Paul Kocialkowski
2015-03-22 16:46 ` Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox