From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] usb: dwc2: fix bulk transfers
Date: Wed, 25 Mar 2015 13:07:58 +0100 [thread overview]
Message-ID: <201503251307.58819.marex@denx.de> (raw)
In-Reply-To: <1427173261-17099-1-git-send-email-swarren@wwwdotorg.org>
On Tuesday, March 24, 2015 at 06:01:01 AM, Stephen Warren wrote:
> When I created wait_for_chhltd(), I noticed that some instances of the
> code it replaced expected the ACK bit to be set and others didn't. I
> assumed this was an accidental inconsistency in the code, so wrote
> wait_for_chhltd() to always expect ACK to be set. This code appeared to
> work correctly for both enumeration of USB keyboards and operation of
> USB Ethernet devices. However, this change broke USB Mass Storage (at
> least my USB SD card reader). This change reverts to exactly the
> original behaviour. I'm not sure why the ACK bit isn't always set
> (perhaps a quirk in the USB HW or DWC2 controller), but the code works
> this way!
>
> Fixes: 5be4ca7d6ac8 ("usb: dwc2: unify waiting for transfer completion")
> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
Applied to topic/dwc2 , which will go to -next. Thanks!
Best regards,
Marek Vasut
prev parent reply other threads:[~2015-03-25 12:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 5:01 [U-Boot] [PATCH] usb: dwc2: fix bulk transfers Stephen Warren
2015-03-25 12:07 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201503251307.58819.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox