From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: implement find_next_zero_bit function
Date: Fri, 27 Mar 2015 20:40:09 +0100 [thread overview]
Message-ID: <20150327204009.2adaf5d7@lilith> (raw)
In-Reply-To: <5515AA27.3010806@ti.com>
Hello Vitaly,
On Fri, 27 Mar 2015 15:06:15 -0400, Vitaly Andrianov <vitalya@ti.com>
wrote:
> Hello Albert,
>
> On 03/27/2015 11:54 AM, Albert ARIBAUD wrote:
> > Hello Vitaly,
> >
> > On Wed, 11 Feb 2015 14:11:12 -0500, Vitaly Andrianov <vitalya@ti.com>
> > wrote:
> >>
> >>
> >> On 02/05/2015 12:52 PM, Albert ARIBAUD wrote:
> >>> Hello Vitaly,
> >>>
> >>> On Thu, 5 Feb 2015 11:24:46 -0500, Vitaly Andrianov <vitalya@ti.com>
> >>> wrote:
> >>>> This commit copies implementation of the find_next_zero_bit() from
> >>>> git://git.denx.de/u-boot.git/arch/mips/include/asm/bitops.h. v2014.07
> >>>>
> >>>> The function is required to enable MCAST_TFTP support for ARM platforms.
> >>>
> >>> Which mainline board needs this?
> >>
> >> TI Keystone2 EVMs
> >
> > Just to make sure: this is actually replacing a 'normal' function with
> > an inline one. So the function /was/ available before this patch,
> > right?
> >
> What inline function are you talking about?
The one you are adding with this patch.
> I couldn't find this function for ARM. That is why I copied it from MIPS.
Thanks -- I had noticed that you were removing extern declarations for
find_first_zero_bit() and find_next_zero_bit() and I was surprised
that this removal was not explained in the commit message, and I had
not realized that the corresponding function definitions did not exist.
I'll apply your patch and add a note in the commit message explaining
the removal.
Amicalement,
--
Albert.
next prev parent reply other threads:[~2015-03-27 19:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 16:24 [U-Boot] [PATCH] arm: implement find_next_zero_bit function Vitaly Andrianov
2015-02-05 17:52 ` Albert ARIBAUD
2015-02-11 19:11 ` Vitaly Andrianov
2015-03-27 15:54 ` Albert ARIBAUD
2015-03-27 19:06 ` Vitaly Andrianov
2015-03-27 19:40 ` Albert ARIBAUD [this message]
2015-04-16 8:52 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150327204009.2adaf5d7@lilith \
--to=albert.u.boot@aribaud.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox