U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Patch to mkenvimage to handle text files with length that exceed env size
Date: Sat, 28 Mar 2015 14:10:41 -0400	[thread overview]
Message-ID: <20150328181041.GS32541@bill-the-cat> (raw)
In-Reply-To: <CADa9hSFxC8UcTV6w_+yrm9_SRTkB-da56FNNWxJ0jtM+yxmc0w@mail.gmail.com>

On Thu, Mar 12, 2015 at 11:52:49AM -0400, Brian McFarland wrote:

> The current head revision of mkenvimage
> (e72be8947e129f5ab274c0a9f235d2cc0014b2ea) will prevent you from creating
> an env image from a text file that is larger than the env length specified
> by the '-s' option.  That doesn't make sense given that the tool now allows
> comments and blank lines.  This patch removes that limitation and allows
> longer text files to be used.
> 
> I don't have time / desire at the moment to figure out "patman" and could
> really care less if this is adopted up stream.  Just figured I would share
> in case anybody else finds it useful enough to take time to do a proper
> patch.
> 
> >From 39ff30190c2bf687861f4b4b33230f1944fb64f9 Mon Sep 17 00:00:00 2001
> From: Brian McFarland <bmcfarland@rldrake.com>
> Date: Thu, 12 Mar 2015 11:37:19 -0400
> Subject: [PATCH] In mkenvimage, removed the check that prevented using a
>  source text file larger than the output environment image.  Instead, the main
>  parsing loop checks to see if the environment buffer is full, and quits if it
>  is.  After the main parse loop, a second loop swallows comments and
>  whitespace until either the EOF is reached or more env vars are found, in
>  which case an error will be thrown.
> 

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150328/a0de2341/attachment.sig>

      parent reply	other threads:[~2015-03-28 18:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12 15:52 [U-Boot] Patch to mkenvimage to handle text files with length that exceed env size Brian McFarland
2015-03-17 19:08 ` [U-Boot] [PATCH] mkenvimage: Handle " Joe Hershberger
2015-03-28 18:10 ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150328181041.GS32541@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox