From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Tue, 31 Mar 2015 23:13:04 +0200 Subject: [U-Boot] [PATCHv3 16/17] arm: socfpga: remove the need to map sdram in arch_early_init In-Reply-To: <1427752878-18426-17-git-send-email-dinguyen@opensource.altera.com> References: <1427752878-18426-1-git-send-email-dinguyen@opensource.altera.com> <1427752878-18426-17-git-send-email-dinguyen@opensource.altera.com> Message-ID: <20150331211304.GF9785@amd> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon 2015-03-30 17:01:17, dinguyen at opensource.altera.com wrote: > From: Dinh Nguyen > > Since we are already mapping sdram 0x0 in board_init_f, we can remove it > here. > > Signed-off-by: Dinh Nguyen > Reviewed-by: Marek Vasut Yes, and you want to merge this to the patch that does that. Also.. what about that "VIRTUAL_TARGET" ifdef? Should not the remap be done in the same place for both? Reviewed-by: Pavel Machek > --- > arch/arm/cpu/armv7/socfpga/misc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/arm/cpu/armv7/socfpga/misc.c b/arch/arm/cpu/armv7/socfpga/misc.c > index 7873c38..3cee6ff 100644 > --- a/arch/arm/cpu/armv7/socfpga/misc.c > +++ b/arch/arm/cpu/armv7/socfpga/misc.c > @@ -205,9 +205,6 @@ int arch_early_init_r(void) > /* Configure the L2 controller to make SDRAM start at 0 */ > #ifdef CONFIG_SOCFPGA_VIRTUAL_TARGET > writel(0x2, &nic301_regs->remap); > -#else > - writel(0x1, &nic301_regs->remap); /* remap.mpuzero */ > - writel(0x1, &pl310->pl310_addr_filter_start); > #endif > > /* Add device descriptor to FPGA device table */ -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html