[U-Boot] [PATCHv3 14/17] arm: socfpga: spl: Add SDRAM check

Pavel Machek
2015-03-31T21:11:18Z

On Mon 2015-03-30 17:01:15, dinguyen at opensource.altera.com wrote:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> ---
> v3: Only report the failure
> v2: Be a bit more verbose about the fail message
> ---
> arch/arm/cpu/armv7/socfpga/spl.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/cpu/armv7/socfpga/spl.c b/arch/arm/cpu/armv7/socfpga/spl.c
> index f2d3f79..dd4d882 100644
> --- a/arch/arm/cpu/armv7/socfpga/spl.c
> +++ b/arch/arm/cpu/armv7/socfpga/spl.c
> @@ -221,4 +221,10 @@ void spl_board_init(void)
>
> sdram_size = sdram_calculate_size();
> debug("SDRAM: %ld MiB\n", sdram_size >> 20);
> +
> + /* Sanity check ensure correct SDRAM size specified */

There's extra space before /*. Plus.. maybe you want to merge this to
previous patch adding the sdram_size calculation? There's no need to
split 4 line patch to two 2 liners...

Reviewed-by: Pavel Machek <pavel@ucw.cz>
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html