From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Date: Thu, 2 Apr 2015 14:47:18 +0200 Subject: [U-Boot] [PATCH 08/12] ARM: socfpga: use "select" instead of default value in defconfig In-Reply-To: References: <1427773686-9790-1-git-send-email-yamada.masahiro@socionext.com> <1427773686-9790-9-git-send-email-yamada.masahiro@socionext.com> <20150331204041.GA9785@amd> Message-ID: <20150402124718.GA32297@amd> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi! > >> Signed-off-by: Masahiro Yamada > >> --- > >> > >> arch/arm/Kconfig | 6 ++++++ > >> configs/socfpga_arria5_defconfig | 3 --- > >> configs/socfpga_cyclone5_defconfig | 3 --- > >> configs/socfpga_socrates_defconfig | 3 --- > >> 4 files changed, 6 insertions(+), 9 deletions(-) > >> > >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > >> index b25a4a9..6ae48c6 100644 > >> --- a/arch/arm/Kconfig > >> +++ b/arch/arm/Kconfig > >> @@ -618,11 +618,17 @@ config TARGET_SOCFPGA_ARRIA5 > >> bool "Support socfpga_arria5" > >> select CPU_V7 > >> select SUPPORT_SPL > >> + select DM > >> + select DM_SPI_FLASH > >> + select DM_SPI > > Are you sure? > > Yes, I'm sure. > > > config DM_SPI_FLASH > > bool "Enable Driver Model for SPI flash" > > depends on DM && SPI > > help > > > > DM_SPI_FLASH depends on SPI, you can't just select it... > > > > > This dependency is wrong. > Before this patch, it must be fixed. > > Please see 01/12 of this series: > http://patchwork.ozlabs.org/patch/456458/ But I'm not sure. With this, you made CONFIG_DM_SPI_FLASH mandatory... even for users that have no SPI flash. There must be better solution...? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html