From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv3 14/17] arm: socfpga: spl: Add SDRAM check
Date: Fri, 3 Apr 2015 03:53:38 +0200 [thread overview]
Message-ID: <201504030353.38418.marex@denx.de> (raw)
In-Reply-To: <20150331211118.GE9785@amd>
On Tuesday, March 31, 2015 at 11:11:18 PM, Pavel Machek wrote:
> On Mon 2015-03-30 17:01:15, dinguyen at opensource.altera.com wrote:
> > From: Dinh Nguyen <dinguyen@opensource.altera.com>
> >
> > Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> > ---
> > v3: Only report the failure
> > v2: Be a bit more verbose about the fail message
> > ---
> >
> > arch/arm/cpu/armv7/socfpga/spl.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm/cpu/armv7/socfpga/spl.c
> > b/arch/arm/cpu/armv7/socfpga/spl.c index f2d3f79..dd4d882 100644
> > --- a/arch/arm/cpu/armv7/socfpga/spl.c
> > +++ b/arch/arm/cpu/armv7/socfpga/spl.c
> > @@ -221,4 +221,10 @@ void spl_board_init(void)
> >
> > sdram_size = sdram_calculate_size();
> > debug("SDRAM: %ld MiB\n", sdram_size >> 20);
> >
> > +
> > + /* Sanity check ensure correct SDRAM size specified */
>
> There's extra space before /*. Plus.. maybe you want to merge this to
> previous patch adding the sdram_size calculation? There's no need to
> split 4 line patch to two 2 liners...
Fixed the extra space (nice catch) and applied, thanks!
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-04-03 1:53 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 22:01 [U-Boot] [PATCHv3 00/17] Add SPL support for SoCFPGA dinguyen at opensource.altera.com
2015-03-30 22:01 ` [U-Boot] [PATCHv3 01/17] arm: socfpga: spl: Add main sdram code dinguyen at opensource.altera.com
2015-03-31 6:41 ` Wolfgang Denk
2015-04-03 2:00 ` Marek Vasut
2015-04-03 4:55 ` Dinh Nguyen
2015-04-03 23:31 ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 02/17] arm: socfpga: spl: Add CONFIG_SPL_MAX_SIZE to be 64KB dinguyen at opensource.altera.com
2015-04-03 1:44 ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 03/17] arm: socfpga: add functions to bring sdram, timer, and uart out of reset dinguyen at opensource.altera.com
2015-04-03 1:45 ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 04/17] arm: socfpga: spl: enable sdram, timer and uart dinguyen at opensource.altera.com
2015-04-03 1:45 ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 05/17] arm: socfpga: spl: Add call to timer_init dinguyen at opensource.altera.com
2015-04-03 1:45 ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 06/17] arm: socfpga: spl: allow bootrom to enable IOs after warm reset dinguyen at opensource.altera.com
2015-04-03 1:46 ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 07/17] arm: socfpga: spl: add sdram init and calibration dinguyen at opensource.altera.com
2015-03-31 21:00 ` Pavel Machek
2015-04-03 1:47 ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 08/17] arm: socfpga: spl: printout sdram size dinguyen at opensource.altera.com
2015-04-03 1:47 ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 09/17] arm: socfpga: spl: Use common lowlevel_init dinguyen at opensource.altera.com
2015-04-03 1:48 ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 10/17] arm: socfpga: spl: Add s_init stub dinguyen at opensource.altera.com
2015-04-03 1:49 ` Marek Vasut
2015-04-07 14:31 ` Dinh Nguyen
2015-04-11 16:57 ` Marek Vasut
2015-04-13 15:20 ` Dinh Nguyen
2015-04-13 15:33 ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 11/17] arm: socfpga: spl: add CONFIG_SPL_STACK to socfpga_common.h dinguyen at opensource.altera.com
2015-04-03 1:50 ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 12/17] arm: socfpga: spl: Adjust the SYS_INIT_RAM_SIZE to have room for the spl malloc dinguyen at opensource.altera.com
2015-04-03 1:51 ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 13/17] arm: socfpga: spl: add board_init_f to SPL dinguyen at opensource.altera.com
2015-03-31 21:07 ` Pavel Machek
2015-04-03 1:52 ` Marek Vasut
2015-04-07 14:34 ` Dinh Nguyen
2015-04-11 16:57 ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 14/17] arm: socfpga: spl: Add SDRAM check dinguyen at opensource.altera.com
2015-03-31 21:11 ` Pavel Machek
2015-04-03 1:53 ` Marek Vasut [this message]
2015-03-30 22:01 ` [U-Boot] [PATCHv3 15/17] arm: socfpga: spl: update pll_config for dev kit dinguyen at opensource.altera.com
2015-04-03 1:54 ` Marek Vasut
2015-04-15 20:49 ` Dinh Nguyen
2015-04-16 6:24 ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 16/17] arm: socfpga: remove the need to map sdram in arch_early_init dinguyen at opensource.altera.com
2015-03-31 21:13 ` Pavel Machek
2015-04-03 1:55 ` Marek Vasut
2015-03-30 22:01 ` [U-Boot] [PATCHv3 17/17] arm: socfpga: fix uart0 pin mux configuration dinguyen at opensource.altera.com
2015-03-31 20:48 ` Pavel Machek
2015-03-31 20:59 ` Dinh Nguyen
2015-03-31 21:13 ` Pavel Machek
2015-04-03 1:57 ` Marek Vasut
2015-04-03 1:56 ` Marek Vasut
2015-03-31 21:14 ` [U-Boot] [PATCHv3 00/17] Add SPL support for SoCFPGA Pavel Machek
2015-04-06 14:40 ` [U-Boot] printf("%d") breaks u-boot 2015.01+ Pavel Machek
2015-04-06 14:59 ` Marek Vasut
2015-04-06 18:14 ` Pavel Machek
2015-04-06 18:48 ` Marek Vasut
2015-04-06 19:23 ` Pavel Machek
2015-04-06 21:02 ` Marek Vasut
2015-04-07 7:53 ` Pavel Machek
2015-04-07 12:23 ` [U-Boot] u-boot 2015.04 on socfpga was " Pavel Machek
2015-04-07 5:13 ` [U-Boot] " Heiko Schocher
2015-04-07 7:56 ` Pavel Machek
2015-04-07 8:16 ` Heiko Schocher
2015-04-08 12:09 ` Pavel Machek
2015-04-08 13:13 ` Marek Vasut
2015-04-08 14:00 ` Pavel Machek
2015-04-13 11:12 ` [U-Boot] "socfpga sdram_applycfg" in mainline u-boot Pavel Machek
2015-04-13 11:24 ` Marek Vasut
2015-04-13 11:29 ` Stefan Roese
2015-04-08 13:49 ` [U-Boot] printf("%d") breaks u-boot 2015.01+ Tom Rini
2015-04-08 14:06 ` Pavel Machek
2015-04-08 15:53 ` Tom Rini
2015-04-08 16:06 ` Pavel Machek
2015-04-08 16:43 ` Tom Rini
2015-04-08 16:08 ` Tom Rini
2015-04-13 12:45 ` Pavel Machek
2015-04-13 12:49 ` [U-Boot] [patch] break build if it would produce broken binary Pavel Machek
2015-04-13 12:52 ` Tom Rini
2015-04-13 20:38 ` Pavel Machek
2015-06-02 17:11 ` Simon Glass
2015-08-13 15:06 ` Pavel Machek
2015-08-13 17:41 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201504030353.38418.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox