From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 3 Apr 2015 03:53:38 +0200 Subject: [U-Boot] [PATCHv3 14/17] arm: socfpga: spl: Add SDRAM check In-Reply-To: <20150331211118.GE9785@amd> References: <1427752878-18426-1-git-send-email-dinguyen@opensource.altera.com> <1427752878-18426-15-git-send-email-dinguyen@opensource.altera.com> <20150331211118.GE9785@amd> Message-ID: <201504030353.38418.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday, March 31, 2015 at 11:11:18 PM, Pavel Machek wrote: > On Mon 2015-03-30 17:01:15, dinguyen at opensource.altera.com wrote: > > From: Dinh Nguyen > > > > Signed-off-by: Dinh Nguyen > > --- > > v3: Only report the failure > > v2: Be a bit more verbose about the fail message > > --- > > > > arch/arm/cpu/armv7/socfpga/spl.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/arm/cpu/armv7/socfpga/spl.c > > b/arch/arm/cpu/armv7/socfpga/spl.c index f2d3f79..dd4d882 100644 > > --- a/arch/arm/cpu/armv7/socfpga/spl.c > > +++ b/arch/arm/cpu/armv7/socfpga/spl.c > > @@ -221,4 +221,10 @@ void spl_board_init(void) > > > > sdram_size = sdram_calculate_size(); > > debug("SDRAM: %ld MiB\n", sdram_size >> 20); > > > > + > > + /* Sanity check ensure correct SDRAM size specified */ > > There's extra space before /*. Plus.. maybe you want to merge this to > previous patch adding the sdram_size calculation? There's no need to > split 4 line patch to two 2 liners... Fixed the extra space (nice catch) and applied, thanks! Best regards, Marek Vasut