From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 3 Apr 2015 10:09:09 +0200 Subject: [U-Boot] [RESEND] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing In-Reply-To: <20150403093500.3bd8020c@amdc2363> References: <1427563369-25318-1-git-send-email-contact@paulk.fr> <201504021911.14524.marex@denx.de> <20150403093500.3bd8020c@amdc2363> Message-ID: <201504031009.09790.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday, April 03, 2015 at 09:35:00 AM, Lukasz Majewski wrote: > Hi Marek, > > > On Monday, March 30, 2015 at 10:06:13 AM, Lukasz Majewski wrote: > > > Hi Paul, > > > > > > > Signed-off-by: Paul Kocialkowski > > > > --- > > > > > > > > common/cmd_fastboot.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c > > > > index 346ab80..7956a5b 100644 > > > > --- a/common/cmd_fastboot.c > > > > +++ b/common/cmd_fastboot.c > > > > @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int > > > > flag, int argc, char *const argv[]) if > > > > (!g_dnl_board_usb_cable_connected()) { puts("\rUSB cable not > > > > detected.\n" \ > > > > > > > > "Command exit.\n"); > > > > > > > > + g_dnl_unregister(); > > > > + g_dnl_clear_detach(); > > > > > > > > return CMD_RET_FAILURE; > > > > > > > > } > > > > > > This is just a minor comment - in your future patches please add > > > some commit message even for this very short patch. > > > > > > Despite that, > > > > > > Acked-by: Lukasz Majewski > > > > > > If other (Marek, Tom) don't mind I will take this through -dfu tree. > > > > Please do, thanks! > > > > btw. is this for current or next release ? > > > > Best regards, > > Marek Vasut > > I thought to add this code in the next merge window, since now we have > -rc5. > > The v2015.04 is scheduled for 13.04. Roger that, thanks! Best regards, Marek Vasut