public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Liu Ying <Ying.Liu@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] imx: ipu: fix occasional hang following disabling of channel
Date: Sat, 4 Apr 2015 22:52:44 +0800	[thread overview]
Message-ID: <20150404145239.GA2422@vbox> (raw)
In-Reply-To: <1428105597-15216-1-git-send-email-tharvey@gateworks.com>

Hi Tim,

Does your code base contain this patch[1]?
It probably addressed the same issue you meet.

[1] http://lists.denx.de/pipermail/u-boot/2014-February/174533.html

Regards,
Liu Ying

On Fri, Apr 03, 2015 at 04:59:57PM -0700, Tim Harvey wrote:
> It has been observed that some IMX6SDL SoC will hang appx 0.1% of boots
> between disabling the ipu channel and disabling DMA preceeding an OS boot
> unless an extra delay is added here.
> 
> The specific cause is still under investigation.
> 
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
>  drivers/video/ipu_common.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/video/ipu_common.c b/drivers/video/ipu_common.c
> index 5873531..3c1bbbb 100644
> --- a/drivers/video/ipu_common.c
> +++ b/drivers/video/ipu_common.c
> @@ -1109,6 +1109,7 @@ int32_t ipu_disable_channel(ipu_channel_t channel)
>  	if ((channel == MEM_BG_SYNC) || (channel == MEM_FG_SYNC) ||
>  	    (channel == MEM_DC_SYNC)) {
>  		ipu_dp_dc_disable(channel, 0);
> +		mdelay(50);
>  	}
>  
>  	/* Disable DMA channel(s) */
> -- 
> 1.9.1
> 

  reply	other threads:[~2015-04-04 14:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-03 23:59 [U-Boot] [PATCH] imx: ipu: fix occasional hang following disabling of channel Tim Harvey
2015-04-04 14:52 ` Liu Ying [this message]
2015-04-06 13:50   ` Tim Harvey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150404145239.GA2422@vbox \
    --to=ying.liu@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox