[U-Boot] [patch] break build if it would produce broken binary

Marek Vasut
2015-08-13T17:41:18Z

On Thursday, August 13, 2015 at 05:06:08 PM, Pavel Machek wrote:
> On Tue 2015-06-02 11:11:35, Simon Glass wrote:
> > Hi,
> >
> > > > > index 43cc494..ae4c21b 100644
> > > > > --- a/arch/arm/include/asm/u-boot.h
> > > > > +++ b/arch/arm/include/asm/u-boot.h
> > > > > @@ -49,4 +49,8 @@ typedef struct bd_info {
> > > > >
> > > > > #define IH_ARCH_DEFAULT IH_ARCH_ARM64
> > > > > #endif
> > > > >
> > > > > +#if defined(CONFIG_USE_PRIVATE_LIBGCC) &&
> > > > > defined(CONFIG_SYS_THUMB_BUILD) +#error Thumb build does not work
> > > > > with private libgcc.
> > > > > +#endif
> > > > > +
> > > > >
> > > > > #endif /* _U_BOOT_H_ */
> > > >
> > > > I'm agreeable to taking this for the release if you'll go and debug
> > > > what's wrong with our private libgcc code for the next release.
> > >
> > > If you are willing to ship u-boot with known and nasty to debug
> > > problem, it is your choice.
> > >
> > > Either the patch is good or it is bad, my future plans should have
> > > nothing to do with it. Notice that this patch does not help _me_ in
> > > any way, as I know about the issue and am unlikely to hit it again,
> > > and that original problem still breaks the build on my system.
>
> ...
>
> > Pavel, your email seemed to me as a little sharp for the mailing list.
>
> Well, I have to survive on the lkml, so I write sharp emails sometimes.

Well, this is not LKML.

Best regards,
Marek Vasut