[U-Boot] [PATCHv3 07/17] arm: socfpga: spl: add sdram init and calibration

Pavel Machek
2015-03-31T21:00:17Z

On Mon 2015-03-30 17:01:08, dinguyen at opensource.altera.com wrote:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>
> Add a call to checkboard along with sdram intilialization and calibration.
>
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> ---
> v3: Use debug instead of puts and add a newline for visual separation
> v2: Add a fail message
> ---
> arch/arm/cpu/armv7/socfpga/spl.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm/cpu/armv7/socfpga/spl.c b/arch/arm/cpu/armv7/socfpga/spl.c
> index 787ad7f..128fe7c 100644
> --- a/arch/arm/cpu/armv7/socfpga/spl.c
> +++ b/arch/arm/cpu/armv7/socfpga/spl.c
> @@ -15,6 +15,7 @@
> #include <asm/arch/freeze_controller.h>
> #include <asm/arch/clock_manager.h>
> #include <asm/arch/scan_manager.h>
> +#include <asm/arch/sdram.h>
>
> DECLARE_GLOBAL_DATA_PTR;
>
> @@ -174,4 +175,16 @@ void spl_board_init(void)
>
> /* enable console uart printing */
> preloader_console_init();
> +
> + if (sdram_mmr_init_full(0xffffffff) != 0) {
> + puts("SDRAM init failed\n");
> + hang();

For consistency, you may want to add "." at end of message.

> + }
> +
> + debug("SDRAM: Calibrating PHY\n");
> + /* SDRAM calibration */
> + if (sdram_calibration_full() == 0) {
> + puts("SDRAM calibration failed!\n");
> + hang();

I'd change ! to . here, but...

Reviewed-by: Pavel Machek <pavel@ucw.cz>
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html