[U-Boot] [PATCHv3 10/17] arm: socfpga: spl: Add s_init stub

Marek Vasut
2015-04-13T15:33:54Z

On Monday, April 13, 2015 at 05:20:38 PM, Dinh Nguyen wrote:
> On 04/11/2015 11:57 AM, Marek Vasut wrote:
> > On Tuesday, April 07, 2015 at 04:31:43 PM, Dinh Nguyen wrote:
> >> On Fri, 3 Apr 2015, Marek Vasut wrote:
> >>> On Tuesday, March 31, 2015 at 12:01:11 AM,
> >>> dinguyen at opensource.altera.com
> >
> > wrote:
> >>>> From: Dinh Nguyen <dinguyen@opensource.altera.com>
> >>>>
> >>>> Add a stub s_init function in the board file.
> >>>
> >>> Why do you add this stub function ? The commit message should
> >>> clarify why the patch is needed.
> >>
> >> I get this error without this patch:
> >>
> >> make: *** [spl/u-boot-spl] Error 2
> >> arch/arm/cpu/armv7/built-in.o: In function `lowlevel_init':
> >> /home/dinguyen/linux_dev/uboot-socfpga/arch/arm/cpu/armv7/lowlevel_init.
> >> S:5 7: undefined reference to `s_init'
> >>
> >> I got the idea that I needed to add this function from this commit
> >> "24a6bc010 arm: Reduce the scope of lowlevel_init()".
> >>
> >> Commit "e755d543 spl_atmel.c: Switch s_init to board_init_f" is alluding
> >> that lowlevel_init is morphing into s_init(), so for now, a stub s_init
> >> is needed?
> >
> > Ah right. Sorry for the noise.
>
> No worries, I should have been more descriptive in my commit message.
> Will try to be in future revisions.

Roger that, thanks!

Best regards,
Marek Vasut