* [U-Boot] [RESEND] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing @ 2015-03-28 17:22 Paul Kocialkowski 2015-03-30 8:06 ` Lukasz Majewski 2015-04-08 9:01 ` Lukasz Majewski 0 siblings, 2 replies; 7+ messages in thread From: Paul Kocialkowski @ 2015-03-28 17:22 UTC (permalink / raw) To: u-boot Signed-off-by: Paul Kocialkowski <contact@paulk.fr> --- common/cmd_fastboot.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c index 346ab80..7956a5b 100644 --- a/common/cmd_fastboot.c +++ b/common/cmd_fastboot.c @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected()) { puts("\rUSB cable not detected.\n" \ "Command exit.\n"); + g_dnl_unregister(); + g_dnl_clear_detach(); return CMD_RET_FAILURE; } -- 1.9.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [RESEND] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing 2015-03-28 17:22 [U-Boot] [RESEND] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing Paul Kocialkowski @ 2015-03-30 8:06 ` Lukasz Majewski 2015-03-30 13:28 ` Paul Kocialkowski 2015-04-02 17:11 ` Marek Vasut 2015-04-08 9:01 ` Lukasz Majewski 1 sibling, 2 replies; 7+ messages in thread From: Lukasz Majewski @ 2015-03-30 8:06 UTC (permalink / raw) To: u-boot Hi Paul, > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > --- > common/cmd_fastboot.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c > index 346ab80..7956a5b 100644 > --- a/common/cmd_fastboot.c > +++ b/common/cmd_fastboot.c > @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, > int argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected()) > { puts("\rUSB cable not detected.\n" \ > "Command exit.\n"); > + g_dnl_unregister(); > + g_dnl_clear_detach(); > return CMD_RET_FAILURE; > } > This is just a minor comment - in your future patches please add some commit message even for this very short patch. Despite that, Acked-by: Lukasz Majewski <l.majewski@samsung.com> If other (Marek, Tom) don't mind I will take this through -dfu tree. -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [RESEND] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing 2015-03-30 8:06 ` Lukasz Majewski @ 2015-03-30 13:28 ` Paul Kocialkowski 2015-04-02 17:11 ` Marek Vasut 1 sibling, 0 replies; 7+ messages in thread From: Paul Kocialkowski @ 2015-03-30 13:28 UTC (permalink / raw) To: u-boot Le lundi 30 mars 2015 ? 10:06 +0200, Lukasz Majewski a ?crit : > Hi Paul, > > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > > --- > > common/cmd_fastboot.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c > > index 346ab80..7956a5b 100644 > > --- a/common/cmd_fastboot.c > > +++ b/common/cmd_fastboot.c > > @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, > > int argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected()) > > { puts("\rUSB cable not detected.\n" \ > > "Command exit.\n"); > > + g_dnl_unregister(); > > + g_dnl_clear_detach(); > > return CMD_RET_FAILURE; > > } > > > > This is just a minor comment - in your future patches please add some > commit message even for this very short patch. Understood. > Despite that, > > Acked-by: Lukasz Majewski <l.majewski@samsung.com> > > If other (Marek, Tom) don't mind I will take this through -dfu tree. Thanks! -- Paul Kocialkowski, Replicant developer Replicant is a fully free Android distribution running on several devices, a free software mobile operating system putting the emphasis on freedom and privacy/security. Website: http://www.replicant.us/ Blog: http://blog.replicant.us/ Wiki/tracker/forums: http://redmine.replicant.us/ -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: This is a digitally signed message part URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150330/ca574223/attachment.sig> ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [RESEND] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing 2015-03-30 8:06 ` Lukasz Majewski 2015-03-30 13:28 ` Paul Kocialkowski @ 2015-04-02 17:11 ` Marek Vasut 2015-04-03 7:35 ` Lukasz Majewski 1 sibling, 1 reply; 7+ messages in thread From: Marek Vasut @ 2015-04-02 17:11 UTC (permalink / raw) To: u-boot On Monday, March 30, 2015 at 10:06:13 AM, Lukasz Majewski wrote: > Hi Paul, > > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > > --- > > > > common/cmd_fastboot.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c > > index 346ab80..7956a5b 100644 > > --- a/common/cmd_fastboot.c > > +++ b/common/cmd_fastboot.c > > @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, > > int argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected()) > > { puts("\rUSB cable not detected.\n" \ > > > > "Command exit.\n"); > > > > + g_dnl_unregister(); > > + g_dnl_clear_detach(); > > > > return CMD_RET_FAILURE; > > > > } > > This is just a minor comment - in your future patches please add some > commit message even for this very short patch. > > Despite that, > > Acked-by: Lukasz Majewski <l.majewski@samsung.com> > > If other (Marek, Tom) don't mind I will take this through -dfu tree. Please do, thanks! btw. is this for current or next release ? Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [RESEND] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing 2015-04-02 17:11 ` Marek Vasut @ 2015-04-03 7:35 ` Lukasz Majewski 2015-04-03 8:09 ` Marek Vasut 0 siblings, 1 reply; 7+ messages in thread From: Lukasz Majewski @ 2015-04-03 7:35 UTC (permalink / raw) To: u-boot Hi Marek, > On Monday, March 30, 2015 at 10:06:13 AM, Lukasz Majewski wrote: > > Hi Paul, > > > > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > > > --- > > > > > > common/cmd_fastboot.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c > > > index 346ab80..7956a5b 100644 > > > --- a/common/cmd_fastboot.c > > > +++ b/common/cmd_fastboot.c > > > @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int > > > flag, int argc, char *const argv[]) if > > > (!g_dnl_board_usb_cable_connected()) { puts("\rUSB cable not > > > detected.\n" \ > > > > > > "Command exit.\n"); > > > > > > + g_dnl_unregister(); > > > + g_dnl_clear_detach(); > > > > > > return CMD_RET_FAILURE; > > > > > > } > > > > This is just a minor comment - in your future patches please add > > some commit message even for this very short patch. > > > > Despite that, > > > > Acked-by: Lukasz Majewski <l.majewski@samsung.com> > > > > If other (Marek, Tom) don't mind I will take this through -dfu tree. > > Please do, thanks! > > btw. is this for current or next release ? > > Best regards, > Marek Vasut I thought to add this code in the next merge window, since now we have -rc5. The v2015.04 is scheduled for 13.04. -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [RESEND] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing 2015-04-03 7:35 ` Lukasz Majewski @ 2015-04-03 8:09 ` Marek Vasut 0 siblings, 0 replies; 7+ messages in thread From: Marek Vasut @ 2015-04-03 8:09 UTC (permalink / raw) To: u-boot On Friday, April 03, 2015 at 09:35:00 AM, Lukasz Majewski wrote: > Hi Marek, > > > On Monday, March 30, 2015 at 10:06:13 AM, Lukasz Majewski wrote: > > > Hi Paul, > > > > > > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > > > > --- > > > > > > > > common/cmd_fastboot.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > > > diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c > > > > index 346ab80..7956a5b 100644 > > > > --- a/common/cmd_fastboot.c > > > > +++ b/common/cmd_fastboot.c > > > > @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int > > > > flag, int argc, char *const argv[]) if > > > > (!g_dnl_board_usb_cable_connected()) { puts("\rUSB cable not > > > > detected.\n" \ > > > > > > > > "Command exit.\n"); > > > > > > > > + g_dnl_unregister(); > > > > + g_dnl_clear_detach(); > > > > > > > > return CMD_RET_FAILURE; > > > > > > > > } > > > > > > This is just a minor comment - in your future patches please add > > > some commit message even for this very short patch. > > > > > > Despite that, > > > > > > Acked-by: Lukasz Majewski <l.majewski@samsung.com> > > > > > > If other (Marek, Tom) don't mind I will take this through -dfu tree. > > > > Please do, thanks! > > > > btw. is this for current or next release ? > > > > Best regards, > > Marek Vasut > > I thought to add this code in the next merge window, since now we have > -rc5. > > The v2015.04 is scheduled for 13.04. Roger that, thanks! Best regards, Marek Vasut ^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [RESEND] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing 2015-03-28 17:22 [U-Boot] [RESEND] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing Paul Kocialkowski 2015-03-30 8:06 ` Lukasz Majewski @ 2015-04-08 9:01 ` Lukasz Majewski 1 sibling, 0 replies; 7+ messages in thread From: Lukasz Majewski @ 2015-04-08 9:01 UTC (permalink / raw) To: u-boot Hi Paul, > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > --- > common/cmd_fastboot.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/common/cmd_fastboot.c b/common/cmd_fastboot.c > index 346ab80..7956a5b 100644 > --- a/common/cmd_fastboot.c > +++ b/common/cmd_fastboot.c > @@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, > int argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected()) > { puts("\rUSB cable not detected.\n" \ > "Command exit.\n"); > + g_dnl_unregister(); > + g_dnl_clear_detach(); > return CMD_RET_FAILURE; > } > Applied to u-boot-dfu branch. Thanks! -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-04-08 9:01 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-03-28 17:22 [U-Boot] [RESEND] [PATCH] fastboot: Proper download gadget unregister and clear when cable is missing Paul Kocialkowski 2015-03-30 8:06 ` Lukasz Majewski 2015-03-30 13:28 ` Paul Kocialkowski 2015-04-02 17:11 ` Marek Vasut 2015-04-03 7:35 ` Lukasz Majewski 2015-04-03 8:09 ` Marek Vasut 2015-04-08 9:01 ` Lukasz Majewski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox