From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Date: Fri, 10 Apr 2015 01:26:27 +0200 Subject: [U-Boot] [RESEND PATCH 5/6] usb: host: Add ehci-vf USB driver for ARM Vybrid SoC's In-Reply-To: References: <201504012115.21957.marex@denx.de> Message-ID: <201504100126.27930.marex@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday, April 09, 2015 at 06:51:45 PM, Fabio Estevam wrote: > Hi Marek, > > On Wed, Apr 1, 2015 at 4:15 PM, Marek Vasut wrote: > >> +#define USB_NC_REG_OFFSET 0x00000800 > >> +#define USBCx_CTRL_OFFSET 0x00000000 > >> +#define USBCx_PHY_CTRL_OFFSET 0x00000018 > > > > Please define the register offsets using the regular struct {} method, > > see for example struct mxs_usbphy_regs and it's usage in ehci-mxs.c . > > I thought we were trying to get rid of the 'no register access via > offset' rule in U-boot. > https://www.marc.info/?l=u-boot&m=142609602127309&w=2 Thanks! Did we reach some agreement on this ? Best regards, Marek Vasut