From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marek Vasut <marex@denx.de>
Date: Sat, 11 Apr 2015 18:57:39 +0200
Subject: [U-Boot] [PATCHv3 10/17] arm: socfpga: spl: Add s_init stub
In-Reply-To: <alpine.DEB.2.02.1504070925540.15562@linux-builds1>
References: <1427752878-18426-1-git-send-email-dinguyen@opensource.altera.com>
 <201504030349.38537.marex@denx.de>
 <alpine.DEB.2.02.1504070925540.15562@linux-builds1>
Message-ID: <201504111857.40046.marex@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tuesday, April 07, 2015 at 04:31:43 PM, Dinh Nguyen wrote:
> On Fri, 3 Apr 2015, Marek Vasut wrote:
> > On Tuesday, March 31, 2015 at 12:01:11 AM, dinguyen at opensource.altera.com 
wrote:
> > > From: Dinh Nguyen <dinguyen@opensource.altera.com>
> > > 
> > > Add a stub s_init function in the board file.
> > 
> > Why do you add this stub function ? The commit message should
> > clarify why the patch is needed.
> 
> I get this error without this patch:
> 
> make: *** [spl/u-boot-spl] Error 2
> arch/arm/cpu/armv7/built-in.o: In function `lowlevel_init':
> /home/dinguyen/linux_dev/uboot-socfpga/arch/arm/cpu/armv7/lowlevel_init.S:5
> 7: undefined reference to `s_init'
> 
> I got the idea that I needed to add this function from this commit
> "24a6bc010 arm: Reduce the scope of lowlevel_init()".
> 
> Commit "e755d543 spl_atmel.c: Switch s_init to board_init_f" is alluding
> that lowlevel_init is morphing into s_init(), so for now, a stub s_init is
> needed?

Ah right. Sorry for the noise.

Best regards,
Marek Vasut